firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Dispose ValueNotifier instances in LicensePage state classes (#104589)

Browse Source
This commit is contained in:
Tomasz Gucio 2022-05-25 20:23:11 +02:00 committed by GitHub
parent 74cfc3db67
commit 7a2b187c7b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/flutter/lib/src/material/about.dart
View File

@ -426,6 +426,12 @@ class LicensePage extends StatefulWidget {
class _LicensePageState extends State<LicensePage> {
final ValueNotifier<int?> selectedId = ValueNotifier<int?>(null);
@override
void dispose() {
selectedId.dispose();
super.dispose();
}
@override
Widget build(BuildContext context) {
return _MasterDetailFlow(
@ -1321,6 +1327,12 @@ class _MasterDetailScaffoldState extends State<_MasterDetailScaffold>
floatingActionButtonLocation = FloatingActionButtonLocation.endTop;
}
@override
void dispose() {
_detailArguments.dispose();
super.dispose();
}
@override
void openDetailPage(Object arguments) {
SchedulerBinding.instance.addPostFrameCallback((_) => _detailArguments.value = arguments);