From 7b0b03bc0df8eecfe2503aa2ea36958fc678e3ba Mon Sep 17 00:00:00 2001 From: Kate Lovett Date: Tue, 15 Oct 2024 13:47:03 -0700 Subject: [PATCH] Adjust timeout for devicelab tests (#156553) Fixes https://github.com/flutter/flutter/issues/156456 There is a known long running test that has been bumping up against the default timeout. This adjusts the perTestTimeout for the devicelab tests to add 15 seconds to stop this from flaking. The test is question: https://github.com/flutter/flutter/blob/82ebb74c6411afc55a8b0937535d6baeb03ea826/dev/devicelab/test/run_test.dart#L76 `test/run_test.dart: run.dart script prints a message after a few seconds when failing to connect (this test takes >10s)` --- dev/bots/suite_runners/run_framework_tests.dart | 5 ++++- dev/devicelab/test/run_test.dart | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/dev/bots/suite_runners/run_framework_tests.dart b/dev/bots/suite_runners/run_framework_tests.dart index d14ecd1d5d..6ad16c7102 100644 --- a/dev/bots/suite_runners/run_framework_tests.dart +++ b/dev/bots/suite_runners/run_framework_tests.dart @@ -235,7 +235,10 @@ Future frameworkTestsRunner() async { tests: [ 'test' ], ); await runDartTest(path.join(flutterRoot, 'dev', 'bots')); - await runDartTest(path.join(flutterRoot, 'dev', 'devicelab'), ensurePrecompiledTool: false); // See https://github.com/flutter/flutter/issues/86209 + await runDartTest( + path.join(flutterRoot, 'dev', 'devicelab'), + ensurePrecompiledTool: false, // See https://github.com/flutter/flutter/issues/86209 + ); await runDartTest(path.join(flutterRoot, 'dev', 'conductor', 'core'), forceSingleCore: true); // TODO(gspencergoog): Remove the exception for fatalWarnings once https://github.com/flutter/flutter/issues/113782 has landed. await runFlutterTest(path.join(flutterRoot, 'dev', 'integration_tests', 'android_semantics_testing'), fatalWarnings: false); diff --git a/dev/devicelab/test/run_test.dart b/dev/devicelab/test/run_test.dart index a68af4e01a..6843e3c17f 100644 --- a/dev/devicelab/test/run_test.dart +++ b/dev/devicelab/test/run_test.dart @@ -91,7 +91,7 @@ void main() { emitsThrough(contains('VM service still not ready. It is possible the target has failed')), ); expect(process.kill(), isTrue); - }); + }, timeout: const Timeout(Duration(seconds: 45))); // Standard 30 is flaky because this is a long running test, https://github.com/flutter/flutter/issues/156456 test('exits with code 1 when results are mixed', () async { await expectScriptResult(