firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

move semantics inside of opacity animation (#19960)

Browse Source
This commit is contained in:
Jonah Williams 2018-07-30 10:44:15 -07:00 committed by GitHub
parent b2eed9a6da
commit 7e2434c8ff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
packages/flutter/lib/src/material/popup_menu.dart
View File

@ -458,13 +458,19 @@ class _PopupMenu<T> extends StatelessWidget {
), ),
child: new IntrinsicWidth( child: new IntrinsicWidth(
stepWidth: _kMenuWidthStep, stepWidth: _kMenuWidthStep,
child: new SingleChildScrollView( child: new Semantics(
padding: const EdgeInsets.symmetric( scopesRoute: true,
vertical: _kMenuVerticalPadding namesRoute: true,
explicitChildNodes: true,
label: semanticLabel,
child: new SingleChildScrollView(
padding: const EdgeInsets.symmetric(
vertical: _kMenuVerticalPadding
),
child: new ListBody(children: children),
), ),
child: new ListBody(children: children), ),
) ),
)
); );
return new AnimatedBuilder( return new AnimatedBuilder(
@ -479,13 +485,7 @@ class _PopupMenu<T> extends StatelessWidget {
alignment: AlignmentDirectional.topEnd, alignment: AlignmentDirectional.topEnd,
widthFactor: width.evaluate(route.animation), widthFactor: width.evaluate(route.animation),
heightFactor: height.evaluate(route.animation), heightFactor: height.evaluate(route.animation),
child: new Semantics( child: child,
scopesRoute: true,
namesRoute: true,
explicitChildNodes: true,
label: semanticLabel,
child: child,
),
), ),
), ),
); );