diff --git a/.ci.yaml b/.ci.yaml index f84b3c480d..63291fc034 100644 --- a/.ci.yaml +++ b/.ci.yaml @@ -4690,7 +4690,8 @@ targets: properties: tags: > ["devicelab", "ios", "mac"] - task_name: hot_mode_dev_cycle_ios__benchmark + # TODO(vashworth): Use "hot_mode_dev_cycle_ios__benchmark" once https://github.com/flutter/flutter/issues/142305 is fixed. + task_name: hot_mode_dev_cycle_ios__benchmark_no_dds - name: Mac_x64 hot_mode_dev_cycle_ios_simulator recipe: devicelab/devicelab_drone diff --git a/TESTOWNERS b/TESTOWNERS index 8bfbd1b63c..fa05098720 100644 --- a/TESTOWNERS +++ b/TESTOWNERS @@ -184,6 +184,8 @@ /dev/devicelab/bin/tasks/fullscreen_textfield_perf_ios__e2e_summary.dart @vashworth @flutter/engine /dev/devicelab/bin/tasks/hello_world_ios__compile.dart @jmagman @flutter/engine /dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios__benchmark.dart @vashworth @flutter/tool +# TODO(vashworth): Remove once https://github.com/flutter/flutter/issues/142305 is fixed. +/dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios__benchmark_no_dds.dart @vashworth @flutter/tool /dev/devicelab/bin/tasks/imagefiltered_transform_animation_perf_ios__timeline_summary.dart @hellohuanlin @flutter/engine /dev/devicelab/bin/tasks/integration_test_test_ios.dart @jmagman @flutter/engine /dev/devicelab/bin/tasks/integration_ui_ios_driver.dart @vashworth @flutter/tool diff --git a/dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios__benchmark_no_dds.dart b/dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios__benchmark_no_dds.dart new file mode 100644 index 0000000000..3f11751891 --- /dev/null +++ b/dev/devicelab/bin/tasks/hot_mode_dev_cycle_ios__benchmark_no_dds.dart @@ -0,0 +1,15 @@ +// Copyright 2014 The Flutter Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +import 'package:flutter_devicelab/framework/devices.dart'; +import 'package:flutter_devicelab/framework/framework.dart'; +import 'package:flutter_devicelab/tasks/hot_mode_tests.dart'; + +Future main() async { + // TODO(vashworth): Remove once https://github.com/flutter/flutter/issues/142305 is fixed. + deviceOperatingSystem = DeviceOperatingSystem.ios; + await task(createHotModeTest( + additionalOptions: ['--no-dds'], + )); +} diff --git a/dev/devicelab/lib/tasks/hot_mode_tests.dart b/dev/devicelab/lib/tasks/hot_mode_tests.dart index 11487a9972..003b7e88ce 100644 --- a/dev/devicelab/lib/tasks/hot_mode_tests.dart +++ b/dev/devicelab/lib/tasks/hot_mode_tests.dart @@ -23,6 +23,7 @@ const String kReplacementLine = 'fontSize: (orientation == Orientation.portrait) TaskFunction createHotModeTest({ String? deviceIdOverride, bool checkAppRunningOnLocalDevice = false, + List? additionalOptions, }) { // This file is modified during the test and needs to be restored at the end. final File flutterFrameworkSource = file(path.join( @@ -47,6 +48,7 @@ TaskFunction createHotModeTest({ '--no-publish-port', '--verbose', '--uninstall-first', + if (additionalOptions != null) ...additionalOptions, ]; int hotReloadCount = 0; late Map smallReloadData;