firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Feature/cpu gpu memory gallery transition tests (#92626)

Browse Source
This commit is contained in:
Ian Hickson 2021-10-28 16:03:03 -07:00 committed by GitHub
parent e5bbaf6630
commit 7f7f487abc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
dev/devicelab/lib/tasks/gallery.dart
View File

@ -47,10 +47,14 @@ class GalleryTransitionTest {
this.timelineTraceFile = 'transitions.timeline', this.timelineTraceFile = 'transitions.timeline',
this.transitionDurationFile = 'transition_durations.timeline', this.transitionDurationFile = 'transition_durations.timeline',
this.driverFile, this.driverFile,
this.measureCpuGpu = true,
this.measureMemory = true,
}); });
final bool semanticsEnabled; final bool semanticsEnabled;
final bool needFullTimeline; final bool needFullTimeline;
final bool measureCpuGpu;
final bool measureMemory;
final String testFile; final String testFile;
final String timelineSummaryFile; final String timelineSummaryFile;
final String? timelineTraceFile; final String? timelineTraceFile;
@ -121,6 +125,7 @@ class GalleryTransitionTest {
summary['missed_transition_count'] = _countMissedTransitions(transitions); summary['missed_transition_count'] = _countMissedTransitions(transitions);
} }
final bool isAndroid = deviceOperatingSystem == DeviceOperatingSystem.android;
return TaskResult.success(summary, return TaskResult.success(summary,
detailFiles: <String>[ detailFiles: <String>[
if (transitionDurationFile != null) if (transitionDurationFile != null)
@ -155,6 +160,17 @@ class GalleryTransitionTest {
'90th_percentile_picture_cache_memory', '90th_percentile_picture_cache_memory',
'99th_percentile_picture_cache_memory', '99th_percentile_picture_cache_memory',
'worst_picture_cache_memory', 'worst_picture_cache_memory',
if (measureCpuGpu && !isAndroid) ...<String>[
// See https://github.com/flutter/flutter/issues/68888
if (summary['average_cpu_usage'] != null) 'average_cpu_usage',
if (summary['average_gpu_usage'] != null) 'average_gpu_usage',
],
if (measureMemory && !isAndroid) ...<String>[
// See https://github.com/flutter/flutter/issues/68888
if (summary['average_memory_usage'] != null) 'average_memory_usage',
if (summary['90th_percentile_memory_usage'] != null) '90th_percentile_memory_usage',
if (summary['99th_percentile_memory_usage'] != null) '99th_percentile_memory_usage',
],
], ],
); );
} }