firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Impeller] use DeviceLocal textures for gifs on non-iOS devices. (#164573)

Browse Source 
Part of https://github.com/flutter/flutter/issues/136365,
https://github.com/flutter/flutter/issues/134399


We only use DeviceLocal on iOS to work around background requirements.
On other platforms there is no need for this.
This commit is contained in:
Jonah Williams 2025-03-04 14:49:22 -08:00 committed by GitHub
parent c7161ad3dd
commit 80aefeb01e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
engine/src/flutter/lib/ui/painting/image_decoder_impeller.cc
View File

@ -466,7 +466,11 @@ ImageDecoderImpeller::UploadTextureToStorage(
} }
impeller::TextureDescriptor texture_descriptor; impeller::TextureDescriptor texture_descriptor;
#ifdef FML_OS_IOS
texture_descriptor.storage_mode = impeller::StorageMode::kHostVisible; texture_descriptor.storage_mode = impeller::StorageMode::kHostVisible;
#else
texture_descriptor.storage_mode = impeller::StorageMode::kDevicePrivate;
#endif // FML_OS_IOS
texture_descriptor.format = pixel_format.value(); texture_descriptor.format = pixel_format.value();
texture_descriptor.size = {image_info.width(), image_info.height()}; texture_descriptor.size = {image_info.width(), image_info.height()};
texture_descriptor.mip_count = 1; texture_descriptor.mip_count = 1;

11
engine/src/flutter/lib/ui/painting/image_decoder_unittests.cc
View File

@ -24,6 +24,7 @@
#include "flutter/testing/test_gl_surface.h" #include "flutter/testing/test_gl_surface.h"
#include "flutter/testing/testing.h" #include "flutter/testing/testing.h"
#include "fml/logging.h" #include "fml/logging.h"
#include "impeller/core/formats.h"
#include "impeller/core/runtime_types.h" #include "impeller/core/runtime_types.h"
#include "impeller/renderer/command_queue.h" #include "impeller/renderer/command_queue.h"
#include "third_party/skia/include/codec/SkCodecAnimation.h" #include "third_party/skia/include/codec/SkCodecAnimation.h"
@ -386,6 +387,16 @@ TEST_F(ImageDecoderFixtureTest, ImpellerUploadToSharedNoGpu) {
ASSERT_EQ(result.second, ""); ASSERT_EQ(result.second, "");
EXPECT_EQ(no_gpu_access_context->DidDisposeResources(), true); EXPECT_EQ(no_gpu_access_context->DidDisposeResources(), true);
#if FML_OS_IOS
EXPECT_EQ(
result.first->impeller_texture()->GetTextureDescriptor().storage_mode,
impeller::StorageMode::kHostVisible);
#else
EXPECT_EQ(
result.first->impeller_texture()->GetTextureDescriptor().storage_mode,
impeller::StorageMode::kDevicePrivate);
#endif // FML_OS_IOS
no_gpu_access_context->FlushTasks(/*fail=*/true); no_gpu_access_context->FlushTasks(/*fail=*/true);
} }