firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make chip test not depend on child order (#94624)

Browse Source
This commit is contained in:
Michael Goderbauer 2021-12-03 13:24:04 -08:00 committed by GitHub
parent b86d189e8f
commit 80f732bc4e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
packages/flutter/test/material/chip_test.dart
View File

@ -46,12 +46,12 @@ IconThemeData getIconData(WidgetTester tester) {
return iconTheme.data; return iconTheme.data;
} }
DefaultTextStyle getLabelStyle(WidgetTester tester) { DefaultTextStyle getLabelStyle(WidgetTester tester, String labelText) {
return tester.widget( return tester.widget(
find.descendant( find.ancestor(
of: find.byType(RawChip), of: find.text(labelText),
matching: find.byType(DefaultTextStyle), matching: find.byType(DefaultTextStyle),
).last, ).first,
); );
} }
@ -295,7 +295,7 @@ void main() {
expect(getIconData(tester).color?.value, 0xffffffff); expect(getIconData(tester).color?.value, 0xffffffff);
expect(getIconData(tester).opacity, null); expect(getIconData(tester).opacity, null);
expect(getIconData(tester).size, null); expect(getIconData(tester).size, null);
expect(getLabelStyle(tester).style.color?.value, 0xde000000); expect(getLabelStyle(tester, 'Chip A').style.color?.value, 0xde000000);
await tester.pumpWidget(buildFrame(Brightness.dark)); await tester.pumpWidget(buildFrame(Brightness.dark));
await tester.pumpAndSettle(); // Theme transition animation await tester.pumpAndSettle(); // Theme transition animation
@ -307,7 +307,7 @@ void main() {
expect(getIconData(tester).color?.value, 0xffffffff); expect(getIconData(tester).color?.value, 0xffffffff);
expect(getIconData(tester).opacity, null); expect(getIconData(tester).opacity, null);
expect(getIconData(tester).size, null); expect(getIconData(tester).size, null);
expect(getLabelStyle(tester).style.color?.value, 0xffffffff); expect(getLabelStyle(tester, 'Chip A').style.color?.value, 0xdeffffff);
}); });
testWidgets('ChoiceChip defaults', (WidgetTester tester) async { testWidgets('ChoiceChip defaults', (WidgetTester tester) async {
@ -331,7 +331,7 @@ void main() {
expect(getMaterial(tester).color, null); expect(getMaterial(tester).color, null);
expect(getMaterial(tester).elevation, 0); expect(getMaterial(tester).elevation, 0);
expect(getMaterial(tester).shape, const StadiumBorder()); expect(getMaterial(tester).shape, const StadiumBorder());
expect(getLabelStyle(tester).style.color?.value, 0xde000000); expect(getLabelStyle(tester, 'Chip A').style.color?.value, 0xde000000);
await tester.pumpWidget(buildFrame(Brightness.dark)); await tester.pumpWidget(buildFrame(Brightness.dark));
await tester.pumpAndSettle(); // Theme transition animation await tester.pumpAndSettle(); // Theme transition animation
@ -340,7 +340,7 @@ void main() {
expect(getMaterial(tester).color, null); expect(getMaterial(tester).color, null);
expect(getMaterial(tester).elevation, 0); expect(getMaterial(tester).elevation, 0);
expect(getMaterial(tester).shape, const StadiumBorder()); expect(getMaterial(tester).shape, const StadiumBorder());
expect(getLabelStyle(tester).style.color?.value, 0xdeffffff); expect(getLabelStyle(tester, 'Chip A').style.color?.value, 0xdeffffff);
}); });
@ -1725,7 +1725,7 @@ void main() {
await tester.pumpWidget(buildChip()); await tester.pumpWidget(buildChip());
final TextStyle labelStyle = getLabelStyle(tester).style; final TextStyle labelStyle = getLabelStyle(tester, 'Label').style;
expect(labelStyle.fontFamily, 'MyFont'); expect(labelStyle.fontFamily, 'MyFont');
expect(labelStyle.fontWeight, FontWeight.w200); expect(labelStyle.fontWeight, FontWeight.w200);
}); });
@ -1827,7 +1827,7 @@ void main() {
RenderBox materialBox = getMaterialBox(tester); RenderBox materialBox = getMaterialBox(tester);
IconThemeData iconData = getIconData(tester); IconThemeData iconData = getIconData(tester);
DefaultTextStyle labelStyle = getLabelStyle(tester); DefaultTextStyle labelStyle = getLabelStyle(tester, 'false');
// Check default theme for enabled widget. // Check default theme for enabled widget.
expect(materialBox, paints..path(color: defaultChipTheme.backgroundColor)); expect(materialBox, paints..path(color: defaultChipTheme.backgroundColor));
@ -1844,7 +1844,7 @@ void main() {
await tester.pumpWidget(buildApp(isSelectable: false)); await tester.pumpWidget(buildApp(isSelectable: false));
await tester.pumpAndSettle(); await tester.pumpAndSettle();
materialBox = getMaterialBox(tester); materialBox = getMaterialBox(tester);
labelStyle = getLabelStyle(tester); labelStyle = getLabelStyle(tester, 'false');
expect(materialBox, paints..path(color: defaultChipTheme.disabledColor)); expect(materialBox, paints..path(color: defaultChipTheme.disabledColor));
expect(labelStyle.style.color, equals(Colors.black.withAlpha(0xde))); expect(labelStyle.style.color, equals(Colors.black.withAlpha(0xde)));
@ -1864,7 +1864,7 @@ void main() {
await tester.pumpAndSettle(); await tester.pumpAndSettle();
materialBox = getMaterialBox(tester); materialBox = getMaterialBox(tester);
iconData = getIconData(tester); iconData = getIconData(tester);
labelStyle = getLabelStyle(tester); labelStyle = getLabelStyle(tester, 'false');
// Check custom theme for enabled widget. // Check custom theme for enabled widget.
expect(materialBox, paints..path(color: customTheme.backgroundColor)); expect(materialBox, paints..path(color: customTheme.backgroundColor));
@ -1884,7 +1884,7 @@ void main() {
)); ));
await tester.pumpAndSettle(); await tester.pumpAndSettle();
materialBox = getMaterialBox(tester); materialBox = getMaterialBox(tester);
labelStyle = getLabelStyle(tester); labelStyle = getLabelStyle(tester, 'false');
expect(materialBox, paints..path(color: customTheme.disabledColor)); expect(materialBox, paints..path(color: customTheme.disabledColor));
expect(labelStyle.style.color, equals(Colors.black.withAlpha(0xde))); expect(labelStyle.style.color, equals(Colors.black.withAlpha(0xde)));
}); });