firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[flutter_tools] mode code size output to ~/.flutter-devtools (#71601)

Browse Source
This commit is contained in:
Jonah Williams 2020-12-02 17:19:57 -08:00 committed by GitHub
parent ece7238402
commit 81e1f7d1ed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
11 changed files with 23 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter_tools/lib/src/android/gradle.dart
View File

@ -532,7 +532,9 @@ Future<void> _performCodeSizeAnalysis(
kind: kind,
);
final File outputFile = globals.fsUtils.getUniqueFile(
globals.fs.directory(getBuildDirectory()),'$kind-code-size-analysis', 'json',
globals.fs
.directory(globals.fsUtils.homeDirPath)
.childDirectory('.flutter-devtools'), '$kind-code-size-analysis', 'json',
)..writeAsStringSync(jsonEncode(output));
// This message is used as a sentinel in analyze_apk_size_test.dart
globals.printStatus(

1
packages/flutter_tools/lib/src/base/file_system.dart
View File

@ -103,6 +103,7 @@ class FileSystemUtils {
final String name = '${baseName}_${i.toString().padLeft(2, '0')}.$ext';
final File file = fs.file(_fileSystem.path.join(dir.path, name));
if (!file.existsSync()) {
file.createSync(recursive: true);
return file;
}
i += 1;

4
packages/flutter_tools/lib/src/commands/build_ios.dart
View File

@ -286,7 +286,9 @@ abstract class _BuildIOSSubCommand extends BuildSubCommand {
type: 'ios',
);
final File outputFile = globals.fsUtils.getUniqueFile(
globals.fs.directory(getBuildDirectory()),'ios-code-size-analysis', 'json',
globals.fs
.directory(globals.fsUtils.homeDirPath)
.childDirectory('.flutter-devtools'), 'ios-code-size-analysis', 'json',
)..writeAsStringSync(jsonEncode(output));
// This message is used as a sentinel in analyze_apk_size_test.dart
globals.printStatus(

4
packages/flutter_tools/lib/src/linux/build_linux.dart
View File

@ -70,7 +70,9 @@ Future<void> buildLinux(
type: 'linux',
);
final File outputFile = globals.fsUtils.getUniqueFile(
globals.fs.directory(getBuildDirectory()),'linux-code-size-analysis', 'json',
globals.fs
.directory(globals.fsUtils.homeDirPath)
.childDirectory('.flutter-devtools'), 'linux-code-size-analysis', 'json',
)..writeAsStringSync(jsonEncode(output));
// This message is used as a sentinel in analyze_apk_size_test.dart
globals.printStatus(

4
packages/flutter_tools/lib/src/macos/build_macos.dart
View File

@ -133,7 +133,9 @@ Future<void> buildMacOS({
excludePath: 'Versions', // Avoid double counting caused by symlinks
);
final File outputFile = globals.fsUtils.getUniqueFile(
globals.fs.directory(getBuildDirectory()), 'macos-code-size-analysis', 'json',
globals.fs
.directory(globals.fsUtils.homeDirPath)
.childDirectory('.flutter-devtools'), 'macos-code-size-analysis', 'json',
)..writeAsStringSync(jsonEncode(output));
// This message is used as a sentinel in analyze_apk_size_test.dart
globals.printStatus(

4
packages/flutter_tools/lib/src/windows/build_windows.dart
View File

@ -78,7 +78,9 @@ Future<void> buildWindows(WindowsProject windowsProject, BuildInfo buildInfo, {
type: 'windows',
);
final File outputFile = globals.fsUtils.getUniqueFile(
globals.fs.directory(getBuildDirectory()),'windows-code-size-analysis', 'json',
globals.fs
.directory(globals.fsUtils.homeDirPath)
.childDirectory('.flutter-devtools'), 'windows-code-size-analysis', 'json',
)..writeAsStringSync(jsonEncode(output));
// This message is used as a sentinel in analyze_apk_size_test.dart
globals.printStatus(

1
packages/flutter_tools/test/commands.shard/hermetic/build_ipa_test.dart
View File

@ -34,6 +34,7 @@ final Platform macosPlatform = FakePlatform(
operatingSystem: 'macos',
environment: <String, String>{
'FLUTTER_ROOT': '/',
'HOME': '/',
}
);
final Platform notMacosPlatform = FakePlatform(

3
packages/flutter_tools/test/commands.shard/hermetic/build_linux_test.dart
View File

@ -26,7 +26,8 @@ const String _kTestFlutterRoot = '/flutter';
final Platform linuxPlatform = FakePlatform(
operatingSystem: 'linux',
environment: <String, String>{
'FLUTTER_ROOT': _kTestFlutterRoot
'FLUTTER_ROOT': _kTestFlutterRoot,
'HOME': '/',
}
);
final Platform notLinuxPlatform = FakePlatform(

3
packages/flutter_tools/test/commands.shard/hermetic/build_macos_test.dart
View File

@ -26,7 +26,7 @@ import '../../src/testbed.dart';
class FakeXcodeProjectInterpreterWithProfile extends FakeXcodeProjectInterpreter {
@override
Future<XcodeProjectInfo> getInfo(String projectPath, {String projectFilename}) async {
Future<XcodeProjectInfo> getInfo(String projectPath, { String projectFilename }) async {
return XcodeProjectInfo(
<String>['Runner'],
<String>['Debug', 'Profile', 'Release'],
@ -40,6 +40,7 @@ final Platform macosPlatform = FakePlatform(
operatingSystem: 'macos',
environment: <String, String>{
'FLUTTER_ROOT': '/',
'HOME': '/',
}
);
final Platform notMacosPlatform = FakePlatform(

1
packages/flutter_tools/test/commands.shard/hermetic/build_windows_test.dart
View File

@ -28,6 +28,7 @@ final Platform windowsPlatform = FakePlatform(
environment: <String, String>{
'PROGRAMFILES(X86)': r'C:\Program Files (x86)\',
'FLUTTER_ROOT': flutterRoot,
'USERPROFILE': '/',
}
);
final Platform notWindowsPlatform = FakePlatform(

1
packages/flutter_tools/test/integration.shard/analyze_size_test.dart
View File

@ -34,6 +34,7 @@ void main() {
final String outputFilePath = line.split(apkDebugMessage).last.trim();
expect(fileSystem.file(fileSystem.path.join(woringDirectory, outputFilePath)), exists);
expect(outputFilePath, contains('.flutter-devtools'));
expect(result.exitCode, 0);
});