From 82f1d639e08e78e9cf4ad7f2f4942c92c5f62563 Mon Sep 17 00:00:00 2001 From: Hans Muller Date: Wed, 24 Mar 2021 17:19:29 -0700 Subject: [PATCH] Removed accentColor dependency from ExpansionTile (#77933) --- .../flutter/lib/src/material/expansion_tile.dart | 6 ++++-- .../flutter/test/material/expansion_tile_test.dart | 12 ++++++------ 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/packages/flutter/lib/src/material/expansion_tile.dart b/packages/flutter/lib/src/material/expansion_tile.dart index c4207e9379..2ea8379cc4 100644 --- a/packages/flutter/lib/src/material/expansion_tile.dart +++ b/packages/flutter/lib/src/material/expansion_tile.dart @@ -4,6 +4,7 @@ import 'package:flutter/widgets.dart'; +import 'color_scheme.dart'; import 'colors.dart'; import 'icons.dart'; import 'list_tile.dart'; @@ -289,13 +290,14 @@ class _ExpansionTileState extends State with SingleTickerProvider @override void didChangeDependencies() { final ThemeData theme = Theme.of(context); + final ColorScheme colorScheme = theme.colorScheme; _borderColorTween.end = theme.dividerColor; _headerColorTween ..begin = widget.collapsedTextColor ?? theme.textTheme.subtitle1!.color - ..end = widget.textColor ?? theme.accentColor; + ..end = widget.textColor ?? colorScheme.secondary; _iconColorTween ..begin = widget.collapsedIconColor ?? theme.unselectedWidgetColor - ..end = widget.iconColor ?? theme.accentColor; + ..end = widget.iconColor ?? colorScheme.secondary; _backgroundColorTween ..begin = widget.collapsedBackgroundColor ..end = widget.backgroundColor; diff --git a/packages/flutter/test/material/expansion_tile_test.dart b/packages/flutter/test/material/expansion_tile_test.dart index 3ec7e77c3a..56ceb7850c 100644 --- a/packages/flutter/test/material/expansion_tile_test.dart +++ b/packages/flutter/test/material/expansion_tile_test.dart @@ -43,7 +43,7 @@ class TestTextState extends State { void main() { const Color _dividerColor = Color(0x1f333333); - const Color _accentColor = Colors.blueAccent; + const Color _foregroundColor = Colors.blueAccent; const Color _unselectedWidgetColor = Colors.black54; const Color _headerColor = Colors.black45; @@ -163,7 +163,7 @@ void main() { await tester.pumpWidget( MaterialApp( theme: ThemeData( - accentColor: _accentColor, + colorScheme: ColorScheme.fromSwatch().copyWith(secondary: _foregroundColor), unselectedWidgetColor: _unselectedWidgetColor, textTheme: const TextTheme(subtitle1: TextStyle(color: _headerColor)), ), @@ -195,9 +195,9 @@ void main() { Color iconColor(Key key) => tester.state(find.byKey(key)).iconTheme.color!; Color textColor(Key key) => tester.state(find.byKey(key)).textStyle.color!; - expect(textColor(expandedTitleKey), _accentColor); + expect(textColor(expandedTitleKey), _foregroundColor); expect(textColor(collapsedTitleKey), _headerColor); - expect(iconColor(expandedIconKey), _accentColor); + expect(iconColor(expandedIconKey), _foregroundColor); expect(iconColor(collapsedIconKey), _unselectedWidgetColor); // Tap both tiles to change their state: collapse and extend respectively @@ -208,9 +208,9 @@ void main() { await tester.pump(const Duration(seconds: 1)); expect(textColor(expandedTitleKey), _headerColor); - expect(textColor(collapsedTitleKey), _accentColor); + expect(textColor(collapsedTitleKey), _foregroundColor); expect(iconColor(expandedIconKey), _unselectedWidgetColor); - expect(iconColor(collapsedIconKey), _accentColor); + expect(iconColor(collapsedIconKey), _foregroundColor); }, variant: const TargetPlatformVariant({ TargetPlatform.iOS, TargetPlatform.macOS })); testWidgets('ExpansionTile subtitle', (WidgetTester tester) async {