firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make _isLocalCreationLocation public (#62891)

Browse Source
This commit is contained in:
Norbert Kozsir 2020-08-06 18:06:07 +02:00 committed by GitHub
parent c54b15b6b2
commit 848cb83b83
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 42 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
packages/flutter/lib/src/widgets/widget_inspector.dart
View File

@ -2860,7 +2860,7 @@ Iterable<DiagnosticsNode> _describeRelevantUserCode(Element element) {
bool processElement(Element target) { bool processElement(Element target) {
// TODO(chunhtai): should print out all the widgets that are about to cross // TODO(chunhtai): should print out all the widgets that are about to cross
// package boundaries. // package boundaries.
if (_isLocalCreationLocation(target)) { if (debugIsLocalCreationLocation(target)) {
nodes.add( nodes.add(
DiagnosticsBlock( DiagnosticsBlock(
name: 'The relevant error-causing widget was', name: 'The relevant error-causing widget was',
@ -2881,15 +2881,22 @@ Iterable<DiagnosticsNode> _describeRelevantUserCode(Element element) {
/// Returns if an object is user created. /// Returns if an object is user created.
/// ///
/// This always returns false if it is not called in debug mode.
///
/// {@macro widgets.inspector.trackCreation} /// {@macro widgets.inspector.trackCreation}
/// ///
/// Currently is local creation locations are only available for /// Currently is local creation locations are only available for
/// [Widget] and [Element]. /// [Widget] and [Element].
bool _isLocalCreationLocation(Object object) { bool debugIsLocalCreationLocation(Object object) {
final _Location location = _getCreationLocation(object); bool isLocal = false;
if (location == null) assert(() {
return false; final _Location location = _getCreationLocation(object);
return WidgetInspectorService.instance._isLocalCreationLocation(location); if (location == null)
isLocal = false;
isLocal = WidgetInspectorService.instance._isLocalCreationLocation(location);
return true;
}());
return isLocal;
} }
/// Returns the creation location of an object in String format if one is available. /// Returns the creation location of an object in String format if one is available.

29
packages/flutter/test/widgets/widget_inspector_test.dart
View File

@ -2748,6 +2748,35 @@ class _TestWidgetInspectorService extends TestWidgetInspectorService {
); );
expect(node.toJsonMap(emptyDelegate), node.toJsonMap(defaultDelegate)); expect(node.toJsonMap(emptyDelegate), node.toJsonMap(defaultDelegate));
}); });
testWidgets('debugIsLocalCreationLocation test', (WidgetTester tester) async {
final GlobalKey key = GlobalKey();
await tester.pumpWidget(
Directionality(
textDirection: TextDirection.ltr,
child: Container(
padding: const EdgeInsets.all(8),
child: Text('target', key: key, textDirection: TextDirection.ltr),
),
),
);
final Element element = key.currentContext as Element;
expect(debugIsLocalCreationLocation(element), isTrue);
expect(debugIsLocalCreationLocation(element.widget), isTrue);
// Padding is inside container
final Finder paddingFinder = find.byType(Padding);
final Element paddingElement = paddingFinder.evaluate().first;
expect(debugIsLocalCreationLocation(paddingElement), isFalse);
expect(debugIsLocalCreationLocation(paddingElement.widget), isFalse);
}, skip: !WidgetInspectorService.instance.isWidgetCreationTracked()); // Test requires --track-widget-creation flag.
} }
} }