firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Terminate flutter test when no longer needed in integration test. (#159117)

Browse Source 
Towards https://github.com/flutter/flutter/issues/51421.

```sh
flutter_tools % dart test test/integration.shard/break_on_framework_exceptions_test.dart

02:38 +29: All tests passed!

54692 ttys003    0:00.02 /opt/homebrew/bin/zsh -il
```

Requires https://github.com/flutter/flutter/pull/159115 for the process
cleanup to work properly, but this is safe to land as-is, otherwise we
still accumulate `flutter` processes over and over as each test case
runs which is not WAI.
This commit is contained in:
Matan Lurey 2024-11-19 08:16:08 -08:00 committed by GitHub
parent c5379557b3
commit 8536b96ebb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 20 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
packages/flutter_tools/test/integration.shard/break_on_framework_exceptions_test.dart
View File

@ -33,23 +33,29 @@ void main() {
final FlutterTestTestDriver flutter = FlutterTestTestDriver(tempDir); final FlutterTestTestDriver flutter = FlutterTestTestDriver(tempDir);
await _timeoutAfter( try {
message: 'Timed out launching `flutter test`', await _timeoutAfter(
work: () => flutter.test(withDebugger: true, pauseOnExceptions: true), message: 'Timed out launching `flutter test`',
); work: () => flutter.test(withDebugger: true, pauseOnExceptions: true),
);
await _timeoutAfter( await _timeoutAfter(
message: 'Timed out waiting for VM service pause debug event', message: 'Timed out waiting for VM service pause debug event',
work: flutter.waitForPause, work: flutter.waitForPause,
); );
int? breakLine; int? breakLine;
await _timeoutAfter( await _timeoutAfter(
message: 'Timed out getting source location of top stack frame', message: 'Timed out getting source location of top stack frame',
work: () async => breakLine = (await flutter.getSourceLocation())?.line, work: () async => breakLine = (await flutter.getSourceLocation())?.line,
); );
expect(breakLine, project.lineContaining(project.test, exceptionMessage)); expect(breakLine, project.lineContaining(project.test, exceptionMessage));
} finally {
// Some of the tests will quit naturally, and others won't.
// By this point we don't need the tool anymore, so just force quit.
await flutter.quit();
}
} }
testWithoutContext('breaks when AnimationController listener throws', () async { testWithoutContext('breaks when AnimationController listener throws', () async {