firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Tracked skipped tests in technical debt benchmark (#9206)

Browse Source
This commit is contained in:
Ian Hickson 2017-04-05 12:23:21 -07:00 committed by GitHub
parent a52c7b470d
commit 86a490ffe8
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dev/devicelab/bin/tasks/technical_debt__cost.dart
View File

@ -14,6 +14,7 @@ import 'package:path/path.dart' as path;
const double todoCost = 1009.0; // about two average SWE days, in dollars const double todoCost = 1009.0; // about two average SWE days, in dollars
const double ignoreCost = 2003.0; // four average SWE days, in dollars const double ignoreCost = 2003.0; // four average SWE days, in dollars
const double pythonCost = 3001.0; // six average SWE days, in dollars const double pythonCost = 3001.0; // six average SWE days, in dollars
const double skipCost = 2473.0; // 20 hours: 5 to fix the issue we're ignoring, 15 to fix the bugs we missed because the test was off
final RegExp todoPattern = new RegExp(r'(?://|#) *TODO'); final RegExp todoPattern = new RegExp(r'(?://|#) *TODO');
final RegExp ignorePattern = new RegExp(r'// *ignore:'); final RegExp ignorePattern = new RegExp(r'// *ignore:');
@ -25,12 +26,15 @@ Future<double> findCostsForFile(File file) async {
path.extension(file.path) != '.yaml' && path.extension(file.path) != '.yaml' &&
path.extension(file.path) != '.sh') path.extension(file.path) != '.sh')
return 0.0; return 0.0;
final bool isTest = file.path.endsWith('_test.dart');
double total = 0.0; double total = 0.0;
for (String line in await file.readAsLines()) { for (String line in await file.readAsLines()) {
if (line.contains(todoPattern)) if (line.contains(todoPattern))
total += todoCost; total += todoCost;
if (line.contains(ignorePattern)) if (line.contains(ignorePattern))
total += ignoreCost; total += ignoreCost;
if (isTest && line.contains('skip:'))
total += skipCost;
} }
return total; return total;
} }