firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update plugin lint test for federated url_launcher plugin (#94374)

Browse Source
This commit is contained in:
Jenn Magder 2021-11-29 12:19:21 -08:00 committed by GitHub
parent c701126481
commit 86b80d1cfe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
dev/devicelab/bin/tasks/plugin_lint_mac.dart
View File

@ -399,7 +399,7 @@ Future<void> main() async {
final File podfileLockFile = File(path.join(swiftAppPath, 'ios', 'Podfile.lock')); final File podfileLockFile = File(path.join(swiftAppPath, 'ios', 'Podfile.lock'));
final String podfileLockOutput = podfileLockFile.readAsStringSync(); final String podfileLockOutput = podfileLockFile.readAsStringSync();
if (!podfileLockOutput.contains(':path: ".symlinks/plugins/url_launcher/ios"') if (!podfileLockOutput.contains(':path: ".symlinks/plugins/url_launcher_ios/ios"')
|| !podfileLockOutput.contains(':path: Flutter') || !podfileLockOutput.contains(':path: Flutter')
// test_plugin_objc no longer supports iOS, shouldn't be present. // test_plugin_objc no longer supports iOS, shouldn't be present.
|| podfileLockOutput.contains(':path: ".symlinks/plugins/test_plugin_objc/ios"') || podfileLockOutput.contains(':path: ".symlinks/plugins/test_plugin_objc/ios"')
@ -417,7 +417,7 @@ Future<void> main() async {
checkDirectoryExists(path.join( checkDirectoryExists(path.join(
pluginSymlinks, pluginSymlinks,
'url_launcher', 'url_launcher_ios',
'ios', 'ios',
)); ));
@ -447,7 +447,7 @@ void _validateIosPodfile(String appPath) {
final File podfileLockFile = File(path.join(appPath, 'ios', 'Podfile.lock')); final File podfileLockFile = File(path.join(appPath, 'ios', 'Podfile.lock'));
final String podfileLockOutput = podfileLockFile.readAsStringSync(); final String podfileLockOutput = podfileLockFile.readAsStringSync();
if (!podfileLockOutput.contains(':path: ".symlinks/plugins/url_launcher/ios"') if (!podfileLockOutput.contains(':path: ".symlinks/plugins/url_launcher_ios/ios"')
|| !podfileLockOutput.contains(':path: Flutter') || !podfileLockOutput.contains(':path: Flutter')
|| !podfileLockOutput.contains(':path: ".symlinks/plugins/test_plugin_objc/ios"') || !podfileLockOutput.contains(':path: ".symlinks/plugins/test_plugin_objc/ios"')
|| !podfileLockOutput.contains(':path: ".symlinks/plugins/test_plugin_swift/ios"') || !podfileLockOutput.contains(':path: ".symlinks/plugins/test_plugin_swift/ios"')
@ -479,7 +479,7 @@ void _validateIosPodfile(String appPath) {
checkDirectoryExists(path.join( checkDirectoryExists(path.join(
pluginSymlinks, pluginSymlinks,
'url_launcher', 'url_launcher_ios',
'ios', 'ios',
)); ));
@ -516,7 +516,7 @@ void _validateMacOSPodfile(String appPath) {
if (!podfileLockOutput.contains(':path: Flutter/ephemeral\n') if (!podfileLockOutput.contains(':path: Flutter/ephemeral\n')
|| !podfileLockOutput.contains(':path: Flutter/ephemeral/.symlinks/plugins/url_launcher_macos/macos') || !podfileLockOutput.contains(':path: Flutter/ephemeral/.symlinks/plugins/url_launcher_macos/macos')
|| !podfileLockOutput.contains(':path: Flutter/ephemeral/.symlinks/plugins/test_plugin_swift/macos') || !podfileLockOutput.contains(':path: Flutter/ephemeral/.symlinks/plugins/test_plugin_swift/macos')
|| podfileLockOutput.contains('url_launcher/')) { || podfileLockOutput.contains('url_launcher_ios/')) {
print(podfileLockOutput); print(podfileLockOutput);
throw TaskResult.failure('macOS Podfile.lock does not contain expected pods'); throw TaskResult.failure('macOS Podfile.lock does not contain expected pods');
} }
@ -546,7 +546,7 @@ void _validateMacOSPodfile(String appPath) {
checkDirectoryNotExists(path.join( checkDirectoryNotExists(path.join(
pluginSymlinks, pluginSymlinks,
'url_launcher', 'url_launcher_ios',
)); ));
checkDirectoryExists(path.join( checkDirectoryExists(path.join(