firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Read --dart-define in RendererBinding.initInstances() (#132408)

Browse Source 
Move `SKPARAGRAPH_REMOVE_ROUNDING_HACK` reading to the framework from `dart:ui` so `flutter run --dart-define="SKPARAGRAPH_REMOVE_ROUNDING_HACK=false"` works
This commit is contained in:
LongCatIsLooong 2023-08-11 18:56:22 -07:00 committed by GitHub
parent 118544972a
commit 881945ddb8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/flutter/lib/src/rendering/binding.dart
View File

@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:ui' as ui show SemanticsUpdate;
import 'dart:ui' as ui show ParagraphBuilder, SemanticsUpdate;
import 'package:flutter/foundation.dart';
import 'package:flutter/gestures.dart';
@ -49,6 +49,11 @@ mixin RendererBinding on BindingBase, ServicesBinding, SchedulerBinding, Gesture
addPostFrameCallback(_handleWebFirstFrame);
}
rootPipelineOwner.attach(_manifold);
// TODO(LongCatIsLooong): clean up after
// https://github.com/flutter/flutter/issues/31707 is fully migrated.
if (!const bool.fromEnvironment('SKPARAGRAPH_REMOVE_ROUNDING_HACK', defaultValue: true)) {
ui.ParagraphBuilder.setDisableRoundingHack(false);
}
}
/// The current [RendererBinding], if one has been created.