firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add missing forwards of local-engine-host in benchmark runners (#133517)

Browse Source 
Some places where we are missing a forward of the `--local-engine-host` values in the benchmark code preventing local running of the benchmarks (does not affect CI usages which don't override local engine).
This commit is contained in:
Jim Graham 2023-08-28 17:31:14 -07:00 committed by GitHub
parent 42e2f4fb3e
commit 88717b3c65
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev/devicelab/bin/run.dart
View File

@ -120,6 +120,7 @@ Future<void> main(List<String> rawArgs) async {
await runTasks(taskNames, await runTasks(taskNames,
silent: silent, silent: silent,
localEngine: localEngine, localEngine: localEngine,
localEngineHost: localEngineHost,
localEngineSrcPath: localEngineSrcPath, localEngineSrcPath: localEngineSrcPath,
deviceId: deviceId, deviceId: deviceId,
exitOnFirstTestFailure: exitOnFirstTestFailure, exitOnFirstTestFailure: exitOnFirstTestFailure,
@ -177,6 +178,7 @@ Future<void> _runABTest({
taskName, taskName,
silent: silent, silent: silent,
localEngine: localEngine, localEngine: localEngine,
localEngineHost: localEngineHost,
localWebSdk: localWebSdk, localWebSdk: localWebSdk,
localEngineSrcPath: localEngineSrcPath, localEngineSrcPath: localEngineSrcPath,
deviceId: deviceId, deviceId: deviceId,