firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid painting previous routes redundantly

Browse Source 
...once the animation is done.
This commit is contained in:
Hixie 2015-10-09 14:03:54 -07:00
parent dfc7f00a88
commit 8915cf0b89
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/flutter/lib/src/widgets/navigator.dart
View File

@ -112,6 +112,16 @@ class NavigatorState extends State<Navigator> {
return index >= 0 && index <= _currentPosition; return index >= 0 && index <= _currentPosition;
} }
void _didCompleteRoute(Route route) {
assert(_history.contains(route));
if (route.isActuallyOpaque) {
setState(() {
// we need to rebuild because our build function depends on
// whether the route is opaque or not.
});
}
}
void _didDismissRoute(Route route) { void _didDismissRoute(Route route) {
assert(_history.contains(route)); assert(_history.contains(route));
if (_history.lastIndexOf(route) <= _currentPosition) if (_history.lastIndexOf(route) <= _currentPosition)
@ -240,7 +250,9 @@ abstract class Route {
} }
void _handlePerformanceStatusChanged(PerformanceStatus status) { void _handlePerformanceStatusChanged(PerformanceStatus status) {
if (status == PerformanceStatus.dismissed) { if (status == PerformanceStatus.completed) {
_navigator._didCompleteRoute(this);
} else if (status == PerformanceStatus.dismissed) {
_navigator._didDismissRoute(this); _navigator._didDismissRoute(this);
_navigator._removeRoute(this); _navigator._removeRoute(this);
_navigator = null; _navigator = null;
@ -266,8 +278,6 @@ abstract class PerformanceRoute extends Route {
Duration get transitionDuration; Duration get transitionDuration;
bool get isActuallyOpaque => (performance == null || _performance.isCompleted) && opaque;
Widget build(NavigatorState navigator, PerformanceView nextRoutePerformance); Widget build(NavigatorState navigator, PerformanceView nextRoutePerformance);
void didPush(NavigatorState navigator) { void didPush(NavigatorState navigator) {