firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use toStringAsFixed in DecorationImage.toString (#131026)

Browse Source 
This makes the output less sensitive on JS int vs double shenanigans.
This commit is contained in:
Ian Hickson 2023-07-24 12:59:06 -07:00 committed by GitHub
parent c53cfc555e
commit 8a01c9b707
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter/lib/src/painting/decoration_image.dart
View File

@ -236,8 +236,8 @@ class DecorationImage {
'$repeat', '$repeat',
if (matchTextDirection) if (matchTextDirection)
'match text direction', 'match text direction',
'scale $scale', 'scale ${scale.toStringAsFixed(1)}',
'opacity $opacity', 'opacity ${opacity.toStringAsFixed(1)}',
'$filterQuality', '$filterQuality',
if (invertColors) if (invertColors)
'invert colors', 'invert colors',

13
packages/flutter/test/painting/decoration_test.dart
View File

@ -333,6 +333,19 @@ void main() {
expect(paint.invertColors, !kIsWeb); expect(paint.invertColors, !kIsWeb);
}); });
test('DecorationImage.toString', () async {
expect(
DecorationImage(
image: SynchronousTestImageProvider(
await createTestImage(width: 100, height: 100),
),
opacity: 0.99,
scale: 2.01,
).toString(),
'DecorationImage(SynchronousTestImageProvider(), Alignment.center, scale 2.0, opacity 1.0, FilterQuality.low)',
);
});
test('DecorationImage with null textDirection configuration should throw Error', () async { test('DecorationImage with null textDirection configuration should throw Error', () async {
const ColorFilter colorFilter = ui.ColorFilter.mode(Color(0xFF00FF00), BlendMode.src); const ColorFilter colorFilter = ui.ColorFilter.mode(Color(0xFF00FF00), BlendMode.src);
final ui.Image image = await createTestImage(width: 100, height: 100); final ui.Image image = await createTestImage(width: 100, height: 100);