From 8b944ea88d070656cd73ba48dbf268aad726de56 Mon Sep 17 00:00:00 2001 From: George Wright Date: Tue, 8 Feb 2022 16:10:43 -0800 Subject: [PATCH] Split complexity scoring tests into two tasks - one for Android and one for iOS (#98063) --- .ci.yaml | 8 ++++---- TESTOWNERS | 3 ++- ...e_complexity_scoring_perf__timeline_summary.dart} | 0 ...he_complexity_scoring_perf__timeline_summary.dart | 12 ++++++++++++ 4 files changed, 18 insertions(+), 5 deletions(-) rename dev/devicelab/bin/tasks/{picture_cache_complexity_scoring_perf__timeline_summary.dart => android_picture_cache_complexity_scoring_perf__timeline_summary.dart} (100%) create mode 100644 dev/devicelab/bin/tasks/ios_picture_cache_complexity_scoring_perf__timeline_summary.dart diff --git a/.ci.yaml b/.ci.yaml index 4231015378..29bc83e4b5 100755 --- a/.ci.yaml +++ b/.ci.yaml @@ -2062,7 +2062,7 @@ targets: task_name: picture_cache_perf__timeline_summary scheduler: luci - - name: Linux_android picture_cache_complexity_scoring_perf__timeline_summary + - name: Linux_android android_picture_cache_complexity_scoring_perf__timeline_summary recipe: devicelab/devicelab_drone bringup: true presubmit: false @@ -2070,7 +2070,7 @@ targets: properties: tags: > ["devicelab","android","linux"] - task_name: picture_cache_complexity_scoring_perf__timeline_summary + task_name: android_picture_cache_complexity_scoring_perf__timeline_summary scheduler: luci - name: Linux_android platform_channels_benchmarks @@ -3382,7 +3382,7 @@ targets: task_name: new_gallery_ios__transition_perf scheduler: luci - - name: Mac_ios picture_cache_complexity_scoring_perf__timeline_summary + - name: Mac_ios ios_picture_cache_complexity_scoring_perf__timeline_summary recipe: devicelab/devicelab_drone bringup: true presubmit: false @@ -3390,7 +3390,7 @@ targets: properties: tags: > ["devicelab","ios","mac"] - task_name: picture_cache_complexity_scoring_perf__timeline_summary + task_name: ios_picture_cache_complexity_scoring_perf__timeline_summary scheduler: luci - name: Mac_ios platform_channel_sample_test_ios diff --git a/TESTOWNERS b/TESTOWNERS index 4af6cfe419..7315767858 100644 --- a/TESTOWNERS +++ b/TESTOWNERS @@ -12,6 +12,7 @@ /dev/devicelab/bin/tasks/analyzer_benchmark.dart @zanderso @flutter/tool /dev/devicelab/bin/tasks/android_defines_test.dart @zanderso @flutter/tool /dev/devicelab/bin/tasks/android_obfuscate_test.dart @zanderso @flutter/tool +/dev/devicelab/bin/tasks/android_picture_cache_complexity_scoring_perf__timeline_summary.dart @flar @flutter/engine /dev/devicelab/bin/tasks/android_stack_size_test.dart @zanderso @flutter/tool /dev/devicelab/bin/tasks/android_view_scroll_perf__timeline_summary.dart @zanderso @flutter/engine /dev/devicelab/bin/tasks/animated_image_gc_perf.dart @zanderso @flutter/engine @@ -113,7 +114,6 @@ /dev/devicelab/bin/tasks/microbenchmarks.dart @zanderso @flutter/engine /dev/devicelab/bin/tasks/new_gallery__transition_perf.dart @zanderso @flutter/engine /dev/devicelab/bin/tasks/picture_cache_perf__timeline_summary.dart @zanderso @flutter/engine -/dev/devicelab/bin/tasks/picture_cache_complexity_scoring_perf__timeline_summary.dart @flar @flutter/engine /dev/devicelab/bin/tasks/platform_channel_sample_test.dart @zanderso @flutter/engine /dev/devicelab/bin/tasks/platform_interaction_test.dart @stuartmorgan @flutter/plugin /dev/devicelab/bin/tasks/platform_view__start_up.dart @zanderso @flutter/engine @@ -152,6 +152,7 @@ /dev/devicelab/bin/tasks/ios_app_with_extensions_test.dart @jmagman @flutter/tool /dev/devicelab/bin/tasks/ios_content_validation_test.dart @jmagman @flutter/tool /dev/devicelab/bin/tasks/ios_defines_test.dart @zanderso @flutter/tool +/dev/devicelab/bin/tasks/ios_picture_cache_complexity_scoring_perf__timeline_summary.dart @flar @flutter/engine /dev/devicelab/bin/tasks/ios_platform_view_tests.dart @stuartmorgan @flutter/plugin /dev/devicelab/bin/tasks/large_image_changer_perf_ios.dart @zanderso @flutter/engine /dev/devicelab/bin/tasks/macos_chrome_dev_mode.dart @zanderso @flutter/tool diff --git a/dev/devicelab/bin/tasks/picture_cache_complexity_scoring_perf__timeline_summary.dart b/dev/devicelab/bin/tasks/android_picture_cache_complexity_scoring_perf__timeline_summary.dart similarity index 100% rename from dev/devicelab/bin/tasks/picture_cache_complexity_scoring_perf__timeline_summary.dart rename to dev/devicelab/bin/tasks/android_picture_cache_complexity_scoring_perf__timeline_summary.dart diff --git a/dev/devicelab/bin/tasks/ios_picture_cache_complexity_scoring_perf__timeline_summary.dart b/dev/devicelab/bin/tasks/ios_picture_cache_complexity_scoring_perf__timeline_summary.dart new file mode 100644 index 0000000000..f06b8bb276 --- /dev/null +++ b/dev/devicelab/bin/tasks/ios_picture_cache_complexity_scoring_perf__timeline_summary.dart @@ -0,0 +1,12 @@ +// Copyright 2014 The Flutter Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +import 'package:flutter_devicelab/framework/devices.dart'; +import 'package:flutter_devicelab/framework/framework.dart'; +import 'package:flutter_devicelab/tasks/perf_tests.dart'; + +Future main() async { + deviceOperatingSystem = DeviceOperatingSystem.ios; + await task(createPictureCacheComplexityScoringPerfTest()); +}