firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Eliminate iOS log blacklist (#11981)

Browse Source 
This was introduced to suppress libMobileGestalt noise originating from
libsystem_asl.dylib. Commit 39680ebfbdf787f81b5765236af0bdce9b64c9c7
suppresses all application log messages not originating from the
app/engine iteself on iOS 10 and above. Since the log message in
question is only emitted on devices running iOS >= 10.3.0, this
blacklist no longer necessary.
This commit is contained in:
Chris Bracken 2017-09-07 10:25:41 -07:00 committed by GitHub
parent 14016523ed
commit 8c61116c00
2 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/flutter_tools/lib/src/ios/devices.dart
View File

@ -385,19 +385,12 @@ class _IOSDeviceLogReader extends DeviceLogReader {
} }
void _onLine(String line) { void _onLine(String line) {
// Lines starting with these strings are suppressed from output as noise.
const List<String> blacklist = const <String>[
'libMobileGestalt ',
];
final Match match = _lineRegex.firstMatch(line); final Match match = _lineRegex.firstMatch(line);
if (match != null) { if (match != null) {
final String logLine = line.substring(match.end); final String logLine = line.substring(match.end);
if (!blacklist.any(logLine.startsWith)) { // Only display the log line after the initial device and executable information.
// Only display the log line after the initial device and executable information. _linesController.add(logLine);
_linesController.add(logLine);
}
} }
} }

2
packages/flutter_tools/test/ios/devices_test.dart
View File

@ -79,7 +79,7 @@ f577a7903cc54959be2e34bc4f7f80b7009efcf4
mockIMobileDevice = new MockIMobileDevice(); mockIMobileDevice = new MockIMobileDevice();
}); });
testUsingContext('suppresses blacklisted lines from output', () async { testUsingContext('suppresses non-Flutter lines from output', () async {
when(mockIMobileDevice.startLogger()).thenAnswer((_) { when(mockIMobileDevice.startLogger()).thenAnswer((_) {
final Process mockProcess = new MockProcess(); final Process mockProcess = new MockProcess();
when(mockProcess.stdout).thenReturn(new Stream<List<int>>.fromIterable(<List<int>>[''' when(mockProcess.stdout).thenReturn(new Stream<List<int>>.fromIterable(<List<int>>['''