From 8cf41e9b4ff900b92d227e5e8cec487ace2dfa67 Mon Sep 17 00:00:00 2001 From: Taha Tesser Date: Tue, 25 Feb 2025 09:32:03 +0200 Subject: [PATCH] Fix `RangeSlider` renders track when track colors are transparent (#162386) ### Description Fixes [`Slider` with transparent track colors and custom `trackHeight` cannot reach the extreme ends](https://github.com/flutter/flutter/issues/161210) but for `RangeSlider`. ### Code Sample
expand to view the code sample ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatefulWidget { const MyApp({super.key}); @override State createState() => _MyAppState(); } class _MyAppState extends State { RangeValues _values = const RangeValues(0, 100); @override Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, home: Scaffold( body: Center( child: Column( spacing: 20, mainAxisSize: MainAxisSize.min, children: [ SliderTheme( data: const SliderThemeData( trackHeight: 100, activeTrackColor: Colors.transparent, inactiveTrackColor: Colors.transparent, ), child: RangeSlider( values: _values, max: 100, onChanged: (RangeValues values) { setState(() { _values = values; }); }, ), ), ], ), ), ), ); } } ```
### Before Screenshot 2025-02-12 at 15 56 21 ### After Screenshot 2025-02-12 at 15 56 09 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --- .../lib/src/material/slider_theme.dart | 9 ++++- .../test/material/slider_theme_test.dart | 39 +++++++++++++++++++ 2 files changed, 47 insertions(+), 1 deletion(-) diff --git a/packages/flutter/lib/src/material/slider_theme.dart b/packages/flutter/lib/src/material/slider_theme.dart index bafbc5fa95..064355fd48 100644 --- a/packages/flutter/lib/src/material/slider_theme.dart +++ b/packages/flutter/lib/src/material/slider_theme.dart @@ -2199,10 +2199,17 @@ mixin BaseRangeSliderTrackShape { sliderTheme.rangeThumbShape!.getPreferredSize(isEnabled, isDiscrete).width; final double overlayWidth = sliderTheme.overlayShape!.getPreferredSize(isEnabled, isDiscrete).width; - final double trackHeight = sliderTheme.trackHeight!; + double trackHeight = sliderTheme.trackHeight!; assert(overlayWidth >= 0); assert(trackHeight >= 0); + // If the track colors are transparent, then override only the track height + // to maintain overall Slider width. + if (sliderTheme.activeTrackColor == Colors.transparent && + sliderTheme.inactiveTrackColor == Colors.transparent) { + trackHeight = 0; + } + final double trackLeft = offset.dx + math.max(overlayWidth / 2, thumbWidth / 2); final double trackTop = offset.dy + (parentBox.size.height - trackHeight) / 2; final double trackRight = trackLeft + parentBox.size.width - math.max(thumbWidth, overlayWidth); diff --git a/packages/flutter/test/material/slider_theme_test.dart b/packages/flutter/test/material/slider_theme_test.dart index 7fcf741434..c0fce54606 100644 --- a/packages/flutter/test/material/slider_theme_test.dart +++ b/packages/flutter/test/material/slider_theme_test.dart @@ -3050,6 +3050,45 @@ void main() { }, ); + // Regression test for https://github.com/flutter/flutter/issues/161210 + testWidgets( + 'RangeSlider with transparent track colors and custom track height can reach extreme ends', + (WidgetTester tester) async { + const double sliderPadding = 24.0; + final ThemeData theme = ThemeData( + sliderTheme: const SliderThemeData( + trackHeight: 100, + activeTrackColor: Colors.transparent, + inactiveTrackColor: Colors.transparent, + ), + ); + + await tester.pumpWidget( + MaterialApp( + theme: theme, + home: Material( + child: SizedBox( + width: 300, + child: RangeSlider( + values: const RangeValues(0, 1), + onChanged: (RangeValues values) {}, + ), + ), + ), + ), + ); + + final MaterialInkController material = Material.of(tester.element(find.byType(RangeSlider))); + + expect( + material, + paints + ..circle(x: sliderPadding, y: 300.0, color: theme.colorScheme.primary) + ..circle(x: 800.0 - sliderPadding, y: 300.0, color: theme.colorScheme.primary), + ); + }, + ); + group('Material 2', () { // These tests are only relevant for Material 2. Once Material 2 // support is deprecated and the APIs are removed, these tests