firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Skip the gallery smoke test (#3736)

Browse Source 
This test hangs occationally on the bots and the bots aren't smart enough to
recover, which means the whole project gets blocked.

Filed #3735 about the hang.
This commit is contained in:
Adam Barth 2016-05-04 13:42:29 -07:00 committed by Ian Hickson
parent 61c003734b
commit 8da98105b4
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
examples/material_gallery/test/smoke_test.dart
View File

@ -94,5 +94,5 @@ void main() {
tester.tap(find.text('Light')); tester.tap(find.text('Light'));
tester.pump(); tester.pump();
tester.pump(const Duration(seconds: 1)); // Wait until it's changed. tester.pump(const Duration(seconds: 1)); // Wait until it's changed.
}); }, skip: true);
} }

5
packages/flutter_test/lib/src/widget_tester.dart
View File

@ -36,13 +36,14 @@ typedef Future<Null> WidgetTesterCallback(WidgetTester widgetTester);
/// expect(tester, hasWidget(find.text('Success'))); /// expect(tester, hasWidget(find.text('Success')));
/// }); /// });
void testWidgets(String description, WidgetTesterCallback callback, { void testWidgets(String description, WidgetTesterCallback callback, {
Timeout timeout: const Timeout(const Duration(seconds: 5)) Timeout timeout: const Timeout(const Duration(seconds: 5)),
bool skip
}) { }) {
TestWidgetsFlutterBinding binding = TestWidgetsFlutterBinding.ensureInitialized(); TestWidgetsFlutterBinding binding = TestWidgetsFlutterBinding.ensureInitialized();
WidgetTester tester = new WidgetTester._(binding); WidgetTester tester = new WidgetTester._(binding);
group('-', () { group('-', () {
setUp(binding.preTest); setUp(binding.preTest);
test(description, () => binding.runTest(() => callback(tester))); test(description, () => binding.runTest(() => callback(tester)), skip: skip);
tearDown(binding.postTest); tearDown(binding.postTest);
}, timeout: timeout); }, timeout: timeout);
} }