From 8de5a07c3f62a6834a1da85eeef3f34109b178ca Mon Sep 17 00:00:00 2001 From: Alexander Aprelev Date: Wed, 13 Feb 2019 15:29:50 -0800 Subject: [PATCH] Revert "Disable usage of bare instructions in AOT (#27410)" (#27789) This reverts commit 965dc52e2e86158a983e502ecfbac07ee29035f4 as performance gains seems to outweigh compressed apk size increase. --- packages/flutter_tools/lib/src/base/build.dart | 1 - packages/flutter_tools/test/base/build_test.dart | 8 -------- 2 files changed, 9 deletions(-) diff --git a/packages/flutter_tools/lib/src/base/build.dart b/packages/flutter_tools/lib/src/base/build.dart index 309f8ff850..a62a353203 100644 --- a/packages/flutter_tools/lib/src/base/build.dart +++ b/packages/flutter_tools/lib/src/base/build.dart @@ -125,7 +125,6 @@ class AOTSnapshotter { final String depfilePath = fs.path.join(outputDir.path, 'snapshot.d'); final List genSnapshotArgs = [ '--deterministic', - '--no-use-bare-instructions', ]; if (extraGenSnapshotOptions != null && extraGenSnapshotOptions.isNotEmpty) { printTrace('Extra gen_snapshot options: $extraGenSnapshotOptions'); diff --git a/packages/flutter_tools/test/base/build_test.dart b/packages/flutter_tools/test/base/build_test.dart index 3fc832eeff..81653adeda 100644 --- a/packages/flutter_tools/test/base/build_test.dart +++ b/packages/flutter_tools/test/base/build_test.dart @@ -193,7 +193,6 @@ void main() { expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.additionalArgs, [ '--deterministic', - '--no-use-bare-instructions', '--snapshot_kind=app-aot-assembly', '--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}', '--no-sim-use-hardfp', @@ -233,7 +232,6 @@ void main() { expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.additionalArgs, [ '--deterministic', - '--no-use-bare-instructions', '--snapshot_kind=app-aot-assembly', '--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}', 'main.dill', @@ -273,7 +271,6 @@ void main() { expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.additionalArgs, [ '--deterministic', - '--no-use-bare-instructions', '--snapshot_kind=app-aot-blobs', '--vm_snapshot_data=build/foo/vm_snapshot_data', '--isolate_snapshot_data=build/foo/isolate_snapshot_data', @@ -318,7 +315,6 @@ void main() { expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.additionalArgs, [ '--deterministic', - '--no-use-bare-instructions', '--snapshot_kind=app-aot-blobs', '--vm_snapshot_data=build/foo/vm_snapshot_data', '--isolate_snapshot_data=build/foo/isolate_snapshot_data', @@ -359,7 +355,6 @@ void main() { expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.additionalArgs, [ '--deterministic', - '--no-use-bare-instructions', '--snapshot_kind=app-aot-assembly', '--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}', '--no-sim-use-hardfp', @@ -399,7 +394,6 @@ void main() { expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.additionalArgs, [ '--deterministic', - '--no-use-bare-instructions', '--snapshot_kind=app-aot-assembly', '--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}', 'main.dill', @@ -457,7 +451,6 @@ void main() { expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.additionalArgs, [ '--deterministic', - '--no-use-bare-instructions', '--snapshot_kind=app-aot-blobs', '--vm_snapshot_data=build/foo/vm_snapshot_data', '--isolate_snapshot_data=build/foo/isolate_snapshot_data', @@ -502,7 +495,6 @@ void main() { expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.additionalArgs, [ '--deterministic', - '--no-use-bare-instructions', '--snapshot_kind=app-aot-blobs', '--vm_snapshot_data=build/foo/vm_snapshot_data', '--isolate_snapshot_data=build/foo/isolate_snapshot_data',