firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prepare for dynamically sized views - pt. 2 (#139079)

Browse Source 
Towards https://github.com/flutter/flutter/issues/134501.

Required to roll https://github.com/flutter/engine/pull/48090 into the framework.

Two new subclasses of FlutterView were added recently for testing (in https://github.com/flutter/flutter/pull/138849) that I missed in my previous PR (https://github.com/flutter/flutter/pull/138565).
This commit is contained in:
Michael Goderbauer 2023-11-27 11:06:00 -08:00 committed by GitHub
parent bf5d2b875f
commit 9147a1c1b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/test/widgets/multi_view_testing.dart
View File

@ -17,7 +17,7 @@ class FakeView extends TestFlutterView {
final int viewId; final int viewId;
@override @override
void render(Scene scene) { void render(Scene scene, {Size? size}) {
// Do not render the scene in the engine. The engine only observes one // Do not render the scene in the engine. The engine only observes one
// instance of FlutterView (the _view), and it is generally expected that // instance of FlutterView (the _view), and it is generally expected that
// the framework will render no more than one `Scene` per frame. // the framework will render no more than one `Scene` per frame.

2
packages/flutter_test/test/multi_view_testing.dart
View File

@ -17,7 +17,7 @@ class FakeView extends TestFlutterView {
final int viewId; final int viewId;
@override @override
void render(Scene scene) { void render(Scene scene, {Size? size}) {
// Do not render the scene in the engine. The engine only observes one // Do not render the scene in the engine. The engine only observes one
// instance of FlutterView (the _view), and it is generally expected that // instance of FlutterView (the _view), and it is generally expected that
// the framework will render no more than one `Scene` per frame. // the framework will render no more than one `Scene` per frame.