firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make these constants private

Browse Source 
These constants aren't useful outside these files and are cause noise in the
dartdoc.
This commit is contained in:
Adam Barth 2015-08-31 15:53:33 -07:00
parent 333e611585
commit 916e4fabe4
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter/lib/widgets/card.dart
View File

@ -6,7 +6,7 @@ import 'package:sky/widgets/basic.dart';
import 'package:sky/widgets/framework.dart'; import 'package:sky/widgets/framework.dart';
import 'package:sky/widgets/material.dart'; import 'package:sky/widgets/material.dart';
const EdgeDims kCardMargins = const EdgeDims.all(4.0); const EdgeDims _kCardMargins = const EdgeDims.all(4.0);
/// A material design card /// A material design card
/// ///
@ -19,7 +19,7 @@ class Card extends Component {
Widget build() { Widget build() {
return new Container( return new Container(
margin: kCardMargins, margin: _kCardMargins,
child: new Material( child: new Material(
color: color, color: color,
type: MaterialType.card, type: MaterialType.card,

8
packages/flutter/lib/widgets/popup_menu_item.dart
View File

@ -10,8 +10,8 @@ import 'package:sky/widgets/gesture_detector.dart';
import 'package:sky/widgets/ink_well.dart'; import 'package:sky/widgets/ink_well.dart';
import 'package:sky/widgets/theme.dart'; import 'package:sky/widgets/theme.dart';
const double kMenuItemHeight = 48.0; const double _kMenuItemHeight = 48.0;
const double kBaselineOffsetFromBottom = 20.0; const double _kBaselineOffsetFromBottom = 20.0;
class PopupMenuItem extends Component { class PopupMenuItem extends Component {
PopupMenuItem({ PopupMenuItem({
@ -30,11 +30,11 @@ class PopupMenuItem extends Component {
onTap: onPressed, onTap: onPressed,
child: new InkWell( child: new InkWell(
child: new Container( child: new Container(
height: kMenuItemHeight, height: _kMenuItemHeight,
child: new DefaultTextStyle( child: new DefaultTextStyle(
style: textStyle, style: textStyle,
child: new Baseline( child: new Baseline(
baseline: kMenuItemHeight - kBaselineOffsetFromBottom, baseline: _kMenuItemHeight - _kBaselineOffsetFromBottom,
child: child child: child
) )
) )