firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Uninstall /can fail/ (#155314)

Browse Source 
Error != Exception.

Fixes #149666
This commit is contained in:
John McDole 2024-09-17 12:17:06 -07:00 committed by GitHub
parent 6fb9a19182
commit 93eabf3558
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
dev/devicelab/bin/tasks/flutter_engine_group_performance.dart
View File

@ -20,13 +20,7 @@ Future<void> _withApkInstall(
final DeviceDiscovery devices = DeviceDiscovery();
final AndroidDevice device = await devices.workingDevice as AndroidDevice;
await device.unlock();
try {
// Force proper cleanup before trying to install app. If uninstall fails,
// we log exception and proceed with running the test.
await device.adb(<String>['uninstall', bundleName]);
} on Exception catch (error) {
print('adb uninstall failed with exception: $error. Will proceed with test run.');
}
await device.adb(<String>['uninstall', bundleName], canFail: true);
await device.adb(<String>['install', '-r', apkPath]);
try {
await body(device);