firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove redundant hide handles API from TextSelectionDelegate (#98944)

Browse Source
This commit is contained in:
chunhtai 2022-02-22 14:44:18 -08:00 committed by GitHub
parent e4351ff053
commit 94f6fd6ea8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/flutter/lib/src/services/text_input.dart
View File

@ -990,13 +990,6 @@ mixin TextSelectionDelegate {
/// updating the text editing state. /// updating the text editing state.
void userUpdateTextEditingValue(TextEditingValue value, SelectionChangedCause cause); void userUpdateTextEditingValue(TextEditingValue value, SelectionChangedCause cause);
/// Hides the text selection toolbar.
///
/// By default, hideHandles is true, and the toolbar is hidden along with its
/// handles. If hideHandles is set to false, then the toolbar will be hidden
/// but the handles will remain.
void hideToolbar([bool hideHandles = true]);
/// Brings the provided [TextPosition] into the visible area of the text /// Brings the provided [TextPosition] into the visible area of the text
/// input. /// input.
void bringIntoView(TextPosition position); void bringIntoView(TextPosition position);

6
packages/flutter/lib/src/widgets/editable_text.dart
View File

@ -2908,7 +2908,11 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
return true; return true;
} }
@override /// Hides the text selection toolbar.
///
/// By default, hideHandles is true, and the toolbar is hidden along with its
/// handles. If hideHandles is set to false, then the toolbar will be hidden
/// but the handles will remain.
void hideToolbar([bool hideHandles = true]) { void hideToolbar([bool hideHandles = true]) {
if (hideHandles) { if (hideHandles) {
// Hide the handles and the toolbar. // Hide the handles and the toolbar.

3
packages/flutter/test/rendering/editable_test.dart
View File

@ -27,9 +27,6 @@ class _FakeEditableTextState with TextSelectionDelegate {
@override @override
TextEditingValue textEditingValue = TextEditingValue.empty; TextEditingValue textEditingValue = TextEditingValue.empty;
@override
void hideToolbar([bool hideHandles = true]) { }
@override @override
void userUpdateTextEditingValue(TextEditingValue value, SelectionChangedCause cause) { } void userUpdateTextEditingValue(TextEditingValue value, SelectionChangedCause cause) { }