From 95e197ba69663b600ecda0768479c3c8308d1025 Mon Sep 17 00:00:00 2001 From: Polina Cherkasova Date: Wed, 30 Aug 2023 16:07:35 -0700 Subject: [PATCH] _RawAutocompleteState should dispose _highlightedOptionIndex. (#133700) --- packages/flutter/lib/src/widgets/autocomplete.dart | 1 + packages/flutter/test/material/autocomplete_test.dart | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/flutter/lib/src/widgets/autocomplete.dart b/packages/flutter/lib/src/widgets/autocomplete.dart index 9f6e226b52..d44ec4d414 100644 --- a/packages/flutter/lib/src/widgets/autocomplete.dart +++ b/packages/flutter/lib/src/widgets/autocomplete.dart @@ -565,6 +565,7 @@ class _RawAutocompleteState extends State> _floatingOptions?.remove(); _floatingOptions?.dispose(); _floatingOptions = null; + _highlightedOptionIndex.dispose(); super.dispose(); } diff --git a/packages/flutter/test/material/autocomplete_test.dart b/packages/flutter/test/material/autocomplete_test.dart index 2113bf6387..e5509beb3c 100644 --- a/packages/flutter/test/material/autocomplete_test.dart +++ b/packages/flutter/test/material/autocomplete_test.dart @@ -5,6 +5,7 @@ import 'package:flutter/material.dart'; import 'package:flutter/services.dart'; import 'package:flutter_test/flutter_test.dart'; +import 'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart'; class User { const User({ @@ -45,7 +46,8 @@ void main() { User(name: 'Charlie', email: 'charlie123@gmail.com'), ]; - testWidgets('can filter and select a list of string options', (WidgetTester tester) async { + testWidgetsWithLeakTracking('can filter and select a list of string options', (WidgetTester tester) async { + late String lastSelection; await tester.pumpWidget( MaterialApp(