firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove Iterator from _History (#132101)

Browse Source 
Cleaning up private code in Navigator.
This commit is contained in:
Justin McCandless 2023-08-08 10:25:27 -07:00 committed by GitHub
parent e60dc3012e
commit 9655311545
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/flutter/lib/src/widgets/navigator.dart
View File

@ -3354,7 +3354,7 @@ typedef _IndexWhereCallback = bool Function(_RouteEntry element);
/// ///
/// Acts as a ChangeNotifier and notifies after its List of _RouteEntries is /// Acts as a ChangeNotifier and notifies after its List of _RouteEntries is
/// mutated. /// mutated.
class _History extends Iterable<_RouteEntry> with ChangeNotifier implements Iterator<_RouteEntry> { class _History extends Iterable<_RouteEntry> with ChangeNotifier {
final List<_RouteEntry> _value = <_RouteEntry>[]; final List<_RouteEntry> _value = <_RouteEntry>[];
int indexWhere(_IndexWhereCallback test, [int start = 0]) { int indexWhere(_IndexWhereCallback test, [int start = 0]) {
@ -3398,10 +3398,6 @@ class _History extends Iterable<_RouteEntry> with ChangeNotifier implements Iter
return entry; return entry;
} }
// Begin Iterator.
int _i = 0;
_RouteEntry operator [](int index) { _RouteEntry operator [](int index) {
return _value[index]; return _value[index];
} }
@ -3411,17 +3407,6 @@ class _History extends Iterable<_RouteEntry> with ChangeNotifier implements Iter
return _value.iterator; return _value.iterator;
} }
@override
_RouteEntry get current => _value[_i];
@override
bool moveNext() {
_i++;
return _i <= _value.length - 1;
}
// End Iterator.
@override @override
String toString() { String toString() {
return _value.toString(); return _value.toString();