firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[web] Add BackgroundIsolateBinaryMessenger.ensureInitialized to web. (#145786)

Browse Source 
This PR makes the static API of the `BackgroundIsolateBinaryMessenger` consistent between its web and IO implementations.

This way, multi-platform applications will compile for the web when using the `ensureInitialized` method (even though it'll throw at runtime, like the `instance` getter, because isolates are not supported on the web).

### Issues

* Fixes: https://github.com/flutter/flutter/issues/145260
This commit is contained in:
David Iglesias 2024-03-26 16:51:23 -07:00 committed by GitHub
parent d2a193804b
commit 9786682492
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dev/bots/test.dart
View File

@ -598,6 +598,12 @@ Future<void> _runBuildTests() async {
path.join('dev', 'integration_tests', 'web_compile_tests'),
path.join('lib', 'dart_io_import.dart'),
),
// Should be able to compile with a call to:
// BackgroundIsolateBinaryMessenger.ensureInitialized.
() => _flutterBuildDart2js(
path.join('dev', 'integration_tests', 'web_compile_tests'),
path.join('lib', 'background_isolate_binary_messenger.dart'),
),
],
runForbiddenFromReleaseTests,
]..shuffle(math.Random(0));

12
dev/integration_tests/web_compile_tests/lib/background_isolate_binary_messenger.dart Normal file
View File

@ -0,0 +1,12 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:ui' as ui;
import 'package:flutter/services.dart';
void main() {
BackgroundIsolateBinaryMessenger.ensureInitialized(
ui.RootIsolateToken.instance!
);
}

6
packages/flutter/lib/src/services/_background_isolate_binary_messenger_web.dart
View File

@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:ui' as ui show RootIsolateToken;
import 'binding.dart';
/// Stand-in for non-web platforms' [BackgroundIsolateBinaryMessenger].
@ -10,4 +11,9 @@ class BackgroundIsolateBinaryMessenger {
static BinaryMessenger get instance {
throw UnsupportedError('Isolates not supported on web.');
}
/// Throws an [UnsupportedError].
static void ensureInitialized(ui.RootIsolateToken token) {
throw UnsupportedError('Isolates not supported on web.');
}
}