firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix SliverPinnedPersistentHeader, also not able to update stretchConfiguration and showOnScreenConfiguration (#112043)

Browse Source
This commit is contained in:
fzyzcjy 2022-09-23 09:43:20 +08:00 committed by GitHub
parent fa2d770c60
commit 97e09c8a78
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 69 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/flutter/lib/src/widgets/sliver_persistent_header.dart
View File

@ -428,6 +428,13 @@ class _SliverPinnedPersistentHeader extends _SliverPersistentHeaderRenderObjectW
showOnScreenConfiguration: delegate.showOnScreenConfiguration,
);
}
@override
void updateRenderObject(BuildContext context, covariant _RenderSliverPinnedPersistentHeaderForWidgets renderObject) {
renderObject
..stretchConfiguration = delegate.stretchConfiguration
..showOnScreenConfiguration = delegate.showOnScreenConfiguration;
}
}
class _RenderSliverPinnedPersistentHeaderForWidgets extends RenderSliverPinnedPersistentHeader

62
packages/flutter/test/widgets/sliver_persistent_header_test.dart
View File

@ -36,6 +36,68 @@ void main() {
.first;
expect(render.stretchConfiguration?.stretchTriggerOffset, 20);
});
testWidgets(
'_SliverPinnedPersistentHeader should update stretchConfiguration',
(WidgetTester tester) async {
for (final double stretchTriggerOffset in <double>[10.0, 20.0]) {
await tester.pumpWidget(MaterialApp(
home: CustomScrollView(
slivers: <Widget>[
SliverPersistentHeader(
pinned: true,
delegate: TestDelegate(
stretchConfiguration: OverScrollHeaderStretchConfiguration(
stretchTriggerOffset: stretchTriggerOffset,
),
),
)
],
),
));
}
expect(
tester.allWidgets.where((Widget w) =>
w.runtimeType.toString() == '_SliverPinnedPersistentHeader'),
isNotEmpty);
final RenderSliverPinnedPersistentHeader render = tester.allRenderObjects
.whereType<RenderSliverPinnedPersistentHeader>()
.first;
expect(render.stretchConfiguration?.stretchTriggerOffset, 20);
});
testWidgets(
'_SliverPinnedPersistentHeader should update showOnScreenConfiguration',
(WidgetTester tester) async {
for (final double maxShowOnScreenExtent in <double>[1000, 2000]) {
await tester.pumpWidget(MaterialApp(
home: CustomScrollView(
slivers: <Widget>[
SliverPersistentHeader(
pinned: true,
delegate: TestDelegate(
showOnScreenConfiguration:
PersistentHeaderShowOnScreenConfiguration(
maxShowOnScreenExtent: maxShowOnScreenExtent),
),
)
],
),
));
}
expect(
tester.allWidgets.where((Widget w) =>
w.runtimeType.toString() == '_SliverPinnedPersistentHeader'),
isNotEmpty);
final RenderSliverPinnedPersistentHeader render = tester.allRenderObjects
.whereType<RenderSliverPinnedPersistentHeader>()
.first;
expect(render.showOnScreenConfiguration?.maxShowOnScreenExtent, 2000);
});
}
class TestDelegate extends SliverPersistentHeaderDelegate {