firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make LocalFileComparator.compare easier to override (#77825)

Browse Source
This commit is contained in:
Kate Lovett 2021-03-10 14:20:04 -06:00 committed by GitHub
parent 0cc087c2ae
commit 9840d65943
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
packages/flutter_test/lib/src/_goldens_io.dart
View File

@ -91,16 +91,9 @@ class LocalFileComparator extends GoldenFileComparator with LocalComparisonOutpu
@override @override
Future<bool> compare(Uint8List imageBytes, Uri golden) async { Future<bool> compare(Uint8List imageBytes, Uri golden) async {
final File goldenFile = _getGoldenFile(golden);
if (!goldenFile.existsSync()) {
throw test_package.TestFailure(
'Could not be compared against non-existent file: "$golden"'
);
}
final List<int> goldenBytes = await goldenFile.readAsBytes();
final ComparisonResult result = await GoldenFileComparator.compareLists( final ComparisonResult result = await GoldenFileComparator.compareLists(
imageBytes, imageBytes,
goldenBytes, await getGoldenBytes(golden),
); );
if (!result.passed) { if (!result.passed) {
@ -117,9 +110,22 @@ class LocalFileComparator extends GoldenFileComparator with LocalComparisonOutpu
await goldenFile.writeAsBytes(imageBytes, flush: true); await goldenFile.writeAsBytes(imageBytes, flush: true);
} }
File _getGoldenFile(Uri golden) { /// Returns the bytes of the given [golden] file.
return File(_path.join(_path.fromUri(basedir), _path.fromUri(golden.path))); ///
/// If the file cannot be found, an error will be thrown.
@protected
Future<List<int>> getGoldenBytes(Uri golden) async {
final File goldenFile = _getGoldenFile(golden);
if (!goldenFile.existsSync()) {
throw test_package.TestFailure(
'Could not be compared against non-existent file: "$golden"'
);
}
final List<int> goldenBytes = await goldenFile.readAsBytes();
return goldenBytes;
} }
File _getGoldenFile(Uri golden) => File(_path.join(_path.fromUri(basedir), _path.fromUri(golden.path)));
} }
/// A class for use in golden file comparators that run locally and provide /// A class for use in golden file comparators that run locally and provide