firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Add initial compile tests (#109177)" (#110550)

Browse Source 
This reverts commit 3437fd9c03f5954aed4e26fcbab7c3f1298281b9.
This commit is contained in:
Jenn Magder 2022-08-29 17:46:31 -07:00 committed by GitHub
parent 8de361154d
commit 99372ba1e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
dev/devicelab/lib/tasks/perf_tests.dart
View File

@ -1359,32 +1359,20 @@ class CompileTest {
return inDirectory<TaskResult>(testDirectory, () async { return inDirectory<TaskResult>(testDirectory, () async {
await flutter('packages', options: <String>['get']); await flutter('packages', options: <String>['get']);
// "initial" compile required downloading and creating the `android/.gradle` directory while "full" final Map<String, dynamic> compileRelease = await _compileApp(reportPackageContentSizes: reportPackageContentSizes);
// compiles only run `flutter clean` between runs. final Map<String, dynamic> compileDebug = await _compileDebug(
final Map<String, dynamic> compileInitialRelease = await _compileApp(deleteGradleCache: true);
final Map<String, dynamic> compileFullRelease = await _compileApp(deleteGradleCache: false);
final Map<String, dynamic> compileInitialDebug = await _compileDebug(
clean: true, clean: true,
deleteGradleCache: true,
metricKey: 'debug_initial_compile_millis',
);
final Map<String, dynamic> compileFullDebug = await _compileDebug(
clean: true,
deleteGradleCache: false,
metricKey: 'debug_full_compile_millis', metricKey: 'debug_full_compile_millis',
); );
// Build again without cleaning, should be faster. // Build again without cleaning, should be faster.
final Map<String, dynamic> compileSecondDebug = await _compileDebug( final Map<String, dynamic> compileSecondDebug = await _compileDebug(
clean: false, clean: false,
deleteGradleCache: false,
metricKey: 'debug_second_compile_millis', metricKey: 'debug_second_compile_millis',
); );
final Map<String, dynamic> metrics = <String, dynamic>{ final Map<String, dynamic> metrics = <String, dynamic>{
...compileInitialRelease, ...compileRelease,
...compileFullRelease, ...compileDebug,
...compileInitialDebug,
...compileFullDebug,
...compileSecondDebug, ...compileSecondDebug,
}; };
@ -1396,7 +1384,6 @@ class CompileTest {
// Build after "edit" without clean should be faster than first build // Build after "edit" without clean should be faster than first build
final Map<String, dynamic> compileAfterEditDebug = await _compileDebug( final Map<String, dynamic> compileAfterEditDebug = await _compileDebug(
clean: false, clean: false,
deleteGradleCache: false,
metricKey: 'debug_compile_after_edit_millis', metricKey: 'debug_compile_after_edit_millis',
); );
metrics.addAll(compileAfterEditDebug); metrics.addAll(compileAfterEditDebug);
@ -1408,12 +1395,8 @@ class CompileTest {
}); });
} }
Future<Map<String, dynamic>> _compileApp({required bool deleteGradleCache}) async { static Future<Map<String, dynamic>> _compileApp({ bool reportPackageContentSizes = false }) async {
await flutter('clean'); await flutter('clean');
if (deleteGradleCache) {
final Directory gradleCacheDir = Directory('$testDirectory/android/.gradle');
gradleCacheDir.deleteSync(recursive: true);
}
final Stopwatch watch = Stopwatch(); final Stopwatch watch = Stopwatch();
int releaseSizeInBytes; int releaseSizeInBytes;
final List<String> options = <String>['--release']; final List<String> options = <String>['--release'];
@ -1519,25 +1502,20 @@ class CompileTest {
} }
metrics.addAll(<String, dynamic>{ metrics.addAll(<String, dynamic>{
'release_${deleteGradleCache ? 'initial' : 'full'}_compile_millis': watch.elapsedMilliseconds, 'release_full_compile_millis': watch.elapsedMilliseconds,
'release_size_bytes': releaseSizeInBytes, 'release_size_bytes': releaseSizeInBytes,
}); });
return metrics; return metrics;
} }
Future<Map<String, dynamic>> _compileDebug({ static Future<Map<String, dynamic>> _compileDebug({
required bool deleteGradleCache,
required bool clean, required bool clean,
required String metricKey, required String metricKey,
}) async { }) async {
if (clean) { if (clean) {
await flutter('clean'); await flutter('clean');
} }
if (deleteGradleCache) {
final Directory gradleCacheDir = Directory('$testDirectory/android/.gradle');
gradleCacheDir.deleteSync(recursive: true);
}
final Stopwatch watch = Stopwatch(); final Stopwatch watch = Stopwatch();
final List<String> options = <String>['--debug']; final List<String> options = <String>['--debug'];
switch (deviceOperatingSystem) { switch (deviceOperatingSystem) {