From 997f742ac56f68bece9787bb00e62b734572c020 Mon Sep 17 00:00:00 2001 From: Matan Lurey Date: Wed, 2 Apr 2025 17:24:34 -0700 Subject: [PATCH] Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (#166455) Unfortunately `10_google3_bug.yml` comes before `2_bug.yml`. This changes the name (slightly) of the issue templates based on the instructions from GitHub on what to do when you have 10+ issue templates (as a side-note: I wonder if we need/still use umbrella bugs for the feature tracker, or two types of performance bugs) --- .../{1_activation.yml => 01_activation.yml} | 0 .../ISSUE_TEMPLATE/{2_bug.yml => 02_bug.yml} | 0 ...ature_request.yml => 03_feature_request.yml} | 0 ...nce_others.yml => 04_performance_others.yml} | 0 ...mance_speed.yml => 05_performance_speed.yml} | 0 ...infrastructure.yml => 06_infrastructure.yml} | 0 .../{7_design_doc.yml => 07_design_doc.yml} | 0 ...packages.yml => 08_first_party_packages.yml} | 0 .../{9_feature.yml => 09_feature.yml} | 0 bin/internal/update_dart_sdk.sh | 2 +- docs/contributing/Design-Documents.md | 2 +- .../Flutter-Framework-Gardener-Rotation.md | 2 +- .../infra/Understanding-a-LUCI-build-failure.md | 2 +- .../Developing-with-Flutter-on-Apple-Silicon.md | 3 ++- engine/src/flutter/docs/impeller/Flutter-GPU.md | 2 +- .../flutter/lib/src/foundation/assertions.dart | 6 +++--- packages/flutter/lib/src/rendering/box.dart | 12 ++++++------ packages/flutter/lib/src/rendering/flex.dart | 2 +- .../flutter/lib/src/semantics/semantics.dart | 2 +- packages/flutter/lib/src/widgets/framework.dart | 2 +- .../test/foundation/assertions_test.dart | 8 ++++---- .../flutter/test/semantics/semantics_test.dart | 4 ++-- .../lib/src/driver/web_driver.dart | 2 +- .../lib/src/l10n/README.md | 17 +++++++---------- packages/flutter_tools/lib/src/cache.dart | 2 +- ...t_package_manager_integration_migration.dart | 2 +- 26 files changed, 35 insertions(+), 37 deletions(-) rename .github/ISSUE_TEMPLATE/{1_activation.yml => 01_activation.yml} (100%) rename .github/ISSUE_TEMPLATE/{2_bug.yml => 02_bug.yml} (100%) rename .github/ISSUE_TEMPLATE/{3_feature_request.yml => 03_feature_request.yml} (100%) rename .github/ISSUE_TEMPLATE/{4_performance_others.yml => 04_performance_others.yml} (100%) rename .github/ISSUE_TEMPLATE/{5_performance_speed.yml => 05_performance_speed.yml} (100%) rename .github/ISSUE_TEMPLATE/{6_infrastructure.yml => 06_infrastructure.yml} (100%) rename .github/ISSUE_TEMPLATE/{7_design_doc.yml => 07_design_doc.yml} (100%) rename .github/ISSUE_TEMPLATE/{8_first_party_packages.yml => 08_first_party_packages.yml} (100%) rename .github/ISSUE_TEMPLATE/{9_feature.yml => 09_feature.yml} (100%) diff --git a/.github/ISSUE_TEMPLATE/1_activation.yml b/.github/ISSUE_TEMPLATE/01_activation.yml similarity index 100% rename from .github/ISSUE_TEMPLATE/1_activation.yml rename to .github/ISSUE_TEMPLATE/01_activation.yml diff --git a/.github/ISSUE_TEMPLATE/2_bug.yml b/.github/ISSUE_TEMPLATE/02_bug.yml similarity index 100% rename from .github/ISSUE_TEMPLATE/2_bug.yml rename to .github/ISSUE_TEMPLATE/02_bug.yml diff --git a/.github/ISSUE_TEMPLATE/3_feature_request.yml b/.github/ISSUE_TEMPLATE/03_feature_request.yml similarity index 100% rename from .github/ISSUE_TEMPLATE/3_feature_request.yml rename to .github/ISSUE_TEMPLATE/03_feature_request.yml diff --git a/.github/ISSUE_TEMPLATE/4_performance_others.yml b/.github/ISSUE_TEMPLATE/04_performance_others.yml similarity index 100% rename from .github/ISSUE_TEMPLATE/4_performance_others.yml rename to .github/ISSUE_TEMPLATE/04_performance_others.yml diff --git a/.github/ISSUE_TEMPLATE/5_performance_speed.yml b/.github/ISSUE_TEMPLATE/05_performance_speed.yml similarity index 100% rename from .github/ISSUE_TEMPLATE/5_performance_speed.yml rename to .github/ISSUE_TEMPLATE/05_performance_speed.yml diff --git a/.github/ISSUE_TEMPLATE/6_infrastructure.yml b/.github/ISSUE_TEMPLATE/06_infrastructure.yml similarity index 100% rename from .github/ISSUE_TEMPLATE/6_infrastructure.yml rename to .github/ISSUE_TEMPLATE/06_infrastructure.yml diff --git a/.github/ISSUE_TEMPLATE/7_design_doc.yml b/.github/ISSUE_TEMPLATE/07_design_doc.yml similarity index 100% rename from .github/ISSUE_TEMPLATE/7_design_doc.yml rename to .github/ISSUE_TEMPLATE/07_design_doc.yml diff --git a/.github/ISSUE_TEMPLATE/8_first_party_packages.yml b/.github/ISSUE_TEMPLATE/08_first_party_packages.yml similarity index 100% rename from .github/ISSUE_TEMPLATE/8_first_party_packages.yml rename to .github/ISSUE_TEMPLATE/08_first_party_packages.yml diff --git a/.github/ISSUE_TEMPLATE/9_feature.yml b/.github/ISSUE_TEMPLATE/09_feature.yml similarity index 100% rename from .github/ISSUE_TEMPLATE/9_feature.yml rename to .github/ISSUE_TEMPLATE/09_feature.yml diff --git a/bin/internal/update_dart_sdk.sh b/bin/internal/update_dart_sdk.sh index edcd99b8c8..9ab6151021 100755 --- a/bin/internal/update_dart_sdk.sh +++ b/bin/internal/update_dart_sdk.sh @@ -171,7 +171,7 @@ if [ ! -f "$ENGINE_STAMP" ] || [ "$ENGINE_VERSION" != `cat "$ENGINE_STAMP"` ]; t >&2 echo >&2 echo "It appears that the downloaded file is corrupt; please try again." >&2 echo "If this problem persists, please report the problem at:" - >&2 echo " https://github.com/flutter/flutter/issues/new?template=1_activation.yml" + >&2 echo " https://github.com/flutter/flutter/issues/new?template=01_activation.yml" >&2 echo rm -f -- "$DART_SDK_ZIP" exit 1 diff --git a/docs/contributing/Design-Documents.md b/docs/contributing/Design-Documents.md index bf0e967dac..56e3c47443 100644 --- a/docs/contributing/Design-Documents.md +++ b/docs/contributing/Design-Documents.md @@ -2,7 +2,7 @@ If you want to write a design doc for people to review, we recommend using Googl We have a template you can use, at [flutter.dev/go/template](https://flutter.dev/go/template). It describes the process for minting a `flutter.dev/go/foo` shortlink for your design doc. We recommend you use that template so that people can immediately recognize that this is a Flutter design document and that it is shared publicly. -After you have created your design doc, the next step is to create a tracking GitHub issue for it. File a new issue to track the design doc using [the design doc issue template](https://github.com/flutter/flutter/issues/new?template=7_design_doc.yml). Assign it to yourself. Add the label "design doc" to the issue. +After you have created your design doc, the next step is to create a tracking GitHub issue for it. File a new issue to track the design doc using [the design doc issue template](https://github.com/flutter/flutter/issues/new?template=07_design_doc.yml). Assign it to yourself. Add the label "design doc" to the issue. Don't forget to configure your document's Sharing settings so that everyone has comment access. The idea of sharing the document in this way is not necessarily to proactively obtain feedback from the entire community; it is to make it _possible_ for people to share the document with anyone in the community, whether they work for your employer or not, and whether you have personally shared the document with them yet or not. diff --git a/docs/infra/Flutter-Framework-Gardener-Rotation.md b/docs/infra/Flutter-Framework-Gardener-Rotation.md index 4849127e3c..562c990d56 100644 --- a/docs/infra/Flutter-Framework-Gardener-Rotation.md +++ b/docs/infra/Flutter-Framework-Gardener-Rotation.md @@ -174,7 +174,7 @@ The bulk of communication happens on [Discord]. [flutter-hackers]: https://github.com/orgs/flutter/teams/flutter-hackers [golden test build breakage]: /docs/contributing/testing/Writing-a-golden-file-test-for-package-flutter.md#build-breakage [new issue]: https://github.com/flutter/flutter/issues/new/choose -[new infra issue]: https://github.com/flutter/flutter/issues/new?template=6_infrastructure.yml +[new infra issue]: https://github.com/flutter/flutter/issues/new?template=06_infrastructure.yml [Framework build dashboard]: https://flutter-dashboard.appspot.com/#/build [framework benchmarks]: https://flutter-flutter-perf.skia.org/e/ diff --git a/docs/infra/Understanding-a-LUCI-build-failure.md b/docs/infra/Understanding-a-LUCI-build-failure.md index f2cc1abcc9..e41e68da6e 100644 --- a/docs/infra/Understanding-a-LUCI-build-failure.md +++ b/docs/infra/Understanding-a-LUCI-build-failure.md @@ -24,7 +24,7 @@ An example build: [Linux color_filter_and_fade_perf__e2e_summary](https://ci.chr ### What to do 1. Check if the infra failure has happened on earlier builds by clicking (i) 2. Check if issue already exists in the [infra bug pool](https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3A%22team%3A+infra%22) -3. If not, file [an infra bug](https://github.com/flutter/flutter/issues/new?template=6_infrastructure.yml) +3. If not, file [an infra bug](https://github.com/flutter/flutter/issues/new?template=06_infrastructure.yml) 5. If you want to get an immediate help, please ask in the discord `hackers-infra` channel 6. If this is an infra flake, and a retry is needed * For pre-submit test, click `Re-run` in the [check run page](https://github.com/flutter/flutter/pull/83894/checks?check_run_id=2738146673). ![The presubmit rerun interface](https://github.com/flutter/assets-for-api-docs/blob/main/assets/wiki/luci_pre_submit_rerun.png) diff --git a/docs/platforms/desktop/macos/Developing-with-Flutter-on-Apple-Silicon.md b/docs/platforms/desktop/macos/Developing-with-Flutter-on-Apple-Silicon.md index 624b61e397..14933d90cd 100644 --- a/docs/platforms/desktop/macos/Developing-with-Flutter-on-Apple-Silicon.md +++ b/docs/platforms/desktop/macos/Developing-with-Flutter-on-Apple-Silicon.md @@ -7,6 +7,7 @@ $ sudo softwareupdate --install-rosetta --agree-to-license ``` If you see CocoaPods crashes related to `ffi`, try reinstalling the Ruby gem with the `--enable-libffi-alloc` flag: + ``` sudo gem uninstall ffi && sudo gem install ffi -- --enable-libffi-alloc ``` @@ -29,4 +30,4 @@ We also plan to offer support for compilation directly to ARM64, as well as univ ## Filing Issues -If you experience a problem relating to using Flutter on Apple Silicon hardware, please [file an issue on GitHub](https://github.com/flutter/flutter/issues/new?template=1_activation.yml) with specific repro steps and information about your hardware and software configuration (paste the results of `flutter doctor -v`). Thank you! \ No newline at end of file +If you experience a problem relating to using Flutter on Apple Silicon hardware, please [file an issue on GitHub](https://github.com/flutter/flutter/issues/new?template=01_activation.yml) with specific repro steps and information about your hardware and software configuration (paste the results of `flutter doctor -v`). Thank you! diff --git a/engine/src/flutter/docs/impeller/Flutter-GPU.md b/engine/src/flutter/docs/impeller/Flutter-GPU.md index 96904589bc..dc0d1e8f77 100644 --- a/engine/src/flutter/docs/impeller/Flutter-GPU.md +++ b/engine/src/flutter/docs/impeller/Flutter-GPU.md @@ -40,4 +40,4 @@ Under the hood, the API communicates with Flutter Engine via Dart FFI, calling s ## Reporting bugs -If you run into issues while using Flutter GPU, please file a bug using the standard [bug report template](https://github.com/flutter/flutter/issues/new?template=2_bug.yml). Additionally, mention "Flutter GPU" in the title, label the bug with the `flutter-gpu` label. +If you run into issues while using Flutter GPU, please file a bug using the standard [bug report template](https://github.com/flutter/flutter/issues/new?template=02_bug.yml). Additionally, mention "Flutter GPU" in the title, label the bug with the `flutter-gpu` label. diff --git a/packages/flutter/lib/src/foundation/assertions.dart b/packages/flutter/lib/src/foundation/assertions.dart index 59263a8434..5c7492f907 100644 --- a/packages/flutter/lib/src/foundation/assertions.dart +++ b/packages/flutter/lib/src/foundation/assertions.dart @@ -717,7 +717,7 @@ class FlutterErrorDetails with Diagnosticable { 'provide substantially more information in this error message to help you determine ' 'and fix the underlying cause.\n' 'In either case, please report this assertion by filing a bug on GitHub:\n' - ' https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + ' https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ), ); } @@ -863,7 +863,7 @@ class FlutterError extends Error with DiagnosticableTreeMixin implements Asserti '\nThis error should still help you solve your problem, ' 'however please also report this malformed error in the ' 'framework by filing a bug on GitHub:\n' - ' https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + ' https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ), ]), ); @@ -900,7 +900,7 @@ class FlutterError extends Error with DiagnosticableTreeMixin implements Asserti '\nThis error should still help you solve your problem, ' 'however please also report this malformed error in the ' 'framework by filing a bug on GitHub:\n' - ' https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + ' https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ), ); throw FlutterError.fromParts(message); diff --git a/packages/flutter/lib/src/rendering/box.dart b/packages/flutter/lib/src/rendering/box.dart index eb57aba61d..aad25e1064 100644 --- a/packages/flutter/lib/src/rendering/box.dart +++ b/packages/flutter/lib/src/rendering/box.dart @@ -2076,7 +2076,7 @@ abstract class RenderBox extends RenderObject { ), ErrorHint( 'If you are not writing your own RenderBox subclass, then this is not\n' - 'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + 'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ), ]), ), @@ -2188,7 +2188,7 @@ abstract class RenderBox extends RenderObject { ), ErrorHint( 'If you are not writing your own RenderBox subclass, then this is not\n' - 'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + 'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ), ]), ), @@ -2646,7 +2646,7 @@ abstract class RenderBox extends RenderObject { DiagnosticsProperty('Size', _size, style: DiagnosticsTreeStyle.errorProperty), ErrorHint( 'If you are not writing your own RenderBox subclass, then this is not ' - 'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + 'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ), ]); } @@ -2738,7 +2738,7 @@ abstract class RenderBox extends RenderObject { ...failures, ErrorHint( 'If you are not writing your own RenderBox subclass, then this is not\n' - 'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + 'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ), ]); } @@ -2764,7 +2764,7 @@ abstract class RenderBox extends RenderObject { ErrorDescription('The constraints used were $constraints.'), ErrorHint( 'If you are not writing your own RenderBox subclass, then this is not\n' - 'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + 'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ), ]); } @@ -2779,7 +2779,7 @@ abstract class RenderBox extends RenderObject { ErrorDescription('The constraints used were $constraints.'), ErrorHint( 'If you are not writing your own RenderBox subclass, then this is not\n' - 'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + 'your fault. Contact support: https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ), ]; diff --git a/packages/flutter/lib/src/rendering/flex.dart b/packages/flutter/lib/src/rendering/flex.dart index c176081c1d..36f58079fe 100644 --- a/packages/flutter/lib/src/rendering/flex.dart +++ b/packages/flutter/lib/src/rendering/flex.dart @@ -1113,7 +1113,7 @@ class RenderFlex extends RenderBox ...addendum, ErrorDescription( "If none of the above helps enough to fix this problem, please don't hesitate to file a bug:\n" - ' https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + ' https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ), ]); return true; diff --git a/packages/flutter/lib/src/semantics/semantics.dart b/packages/flutter/lib/src/semantics/semantics.dart index 1cc89130c9..6d0cc29be8 100644 --- a/packages/flutter/lib/src/semantics/semantics.dart +++ b/packages/flutter/lib/src/semantics/semantics.dart @@ -4143,7 +4143,7 @@ class SemanticsOwner extends ChangeNotifier { ErrorHint( 'Consider removing the above invisible SemanticsNodes if they were added by your ' 'RenderObject.assembleSemanticsNode implementation, or filing a bug on GitHub:\n' - ' https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + ' https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ), ]); }()); diff --git a/packages/flutter/lib/src/widgets/framework.dart b/packages/flutter/lib/src/widgets/framework.dart index 8e85b267ef..cb62853a73 100644 --- a/packages/flutter/lib/src/widgets/framework.dart +++ b/packages/flutter/lib/src/widgets/framework.dart @@ -2899,7 +2899,7 @@ class BuildOwner { ErrorHint( 'If you did not attempt to call scheduleBuildFor() yourself, then this probably ' 'indicates a bug in the widgets framework. Please report it:\n' - ' https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + ' https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ), ]); } diff --git a/packages/flutter/test/foundation/assertions_test.dart b/packages/flutter/test/foundation/assertions_test.dart index 5c2e65bcdc..c3470bcb3f 100644 --- a/packages/flutter/test/foundation/assertions_test.dart +++ b/packages/flutter/test/foundation/assertions_test.dart @@ -240,7 +240,7 @@ void main() { 'This error should still help you solve your problem, however\n' 'please also report this malformed error in the framework by\n' 'filing a bug on GitHub:\n' - ' https://github.com/flutter/flutter/issues/new?template=2_bug.yml\n' + ' https://github.com/flutter/flutter/issues/new?template=02_bug.yml\n' '═════════════════════════════════════════════════════════════════\n', ); } @@ -277,7 +277,7 @@ void main() { 'This error should still help you solve your problem, however\n' 'please also report this malformed error in the framework by\n' 'filing a bug on GitHub:\n' - ' https://github.com/flutter/flutter/issues/new?template=2_bug.yml\n' + ' https://github.com/flutter/flutter/issues/new?template=02_bug.yml\n' '═════════════════════════════════════════════════════════════════\n', ); } @@ -306,7 +306,7 @@ void main() { 'This error should still help you solve your problem, however\n' 'please also report this malformed error in the framework by\n' 'filing a bug on GitHub:\n' - ' https://github.com/flutter/flutter/issues/new?template=2_bug.yml\n' + ' https://github.com/flutter/flutter/issues/new?template=02_bug.yml\n' '═════════════════════════════════════════════════════════════════\n', ); } @@ -406,7 +406,7 @@ void main() { 'provide substantially more information in this error message to help you determine ' 'and fix the underlying cause.\n' 'In either case, please report this assertion by filing a bug on GitHub:\n' - ' https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + ' https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ); expect(builder.properties[4] is ErrorSpacer, true); final DiagnosticsStackTrace trace = builder.properties[5] as DiagnosticsStackTrace; diff --git a/packages/flutter/test/semantics/semantics_test.dart b/packages/flutter/test/semantics/semantics_test.dart index 418f02969c..f30ec10080 100644 --- a/packages/flutter/test/semantics/semantics_test.dart +++ b/packages/flutter/test/semantics/semantics_test.dart @@ -291,7 +291,7 @@ void main() { 'An invisible SemanticsNode is one whose rect is not on screen hence not reachable for users, and its semantic information is not merged into a visible parent.\n' 'An invisible SemanticsNode makes the accessibility experience confusing, as it does not provide any visual indication when the user selects it via accessibility technologies.\n' 'Consider removing the above invisible SemanticsNodes if they were added by your RenderObject.assembleSemanticsNode implementation, or filing a bug on GitHub:\n' - ' https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + ' https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ), ), ), @@ -322,7 +322,7 @@ void main() { 'An invisible SemanticsNode is one whose rect is not on screen hence not reachable for users, and its semantic information is not merged into a visible parent.\n' 'An invisible SemanticsNode makes the accessibility experience confusing, as it does not provide any visual indication when the user selects it via accessibility technologies.\n' 'Consider removing the above invisible SemanticsNodes if they were added by your RenderObject.assembleSemanticsNode implementation, or filing a bug on GitHub:\n' - ' https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + ' https://github.com/flutter/flutter/issues/new?template=02_bug.yml', ), ), ), diff --git a/packages/flutter_driver/lib/src/driver/web_driver.dart b/packages/flutter_driver/lib/src/driver/web_driver.dart index 3bdf62c300..49e6e13bd0 100644 --- a/packages/flutter_driver/lib/src/driver/web_driver.dart +++ b/packages/flutter_driver/lib/src/driver/web_driver.dart @@ -323,7 +323,7 @@ class FlutterWebConnection { 'If the test uses VM service extensions provided by the Flutter SDK, ' 'then this error is likely caused by a bug in Flutter. Please report it ' 'by filing a bug on GitHub:\n' - ' https://github.com/flutter/flutter/issues/new?template=2_bug.yml', + ' https://github.com/flutter/flutter/issues/new?template=02_bug.yml', error, stackTrace, ); diff --git a/packages/flutter_localizations/lib/src/l10n/README.md b/packages/flutter_localizations/lib/src/l10n/README.md index 7c5fffca7f..4124b0a913 100644 --- a/packages/flutter_localizations/lib/src/l10n/README.md +++ b/packages/flutter_localizations/lib/src/l10n/README.md @@ -1,7 +1,7 @@ # Material and Cupertino Libraries Localizations The `.arb` files in this directory contain localized values (primarily -strings) used by the Material and Cupertino libraries. The +strings) used by the Material and Cupertino libraries. The `generated_material_localizations.dart` and `generated_cupertino_localizations.dart` files combine all of the localizations into a single Map that is linked with the rest of @@ -11,7 +11,6 @@ If you're looking for information about internationalizing Flutter apps in general, see the [Internationalizing Flutter Apps](https://flutter.dev/to/internationalization) tutorial. - ### Translations for one locale: .arb files The Material and Cupertino libraries use @@ -80,7 +79,6 @@ to write. }, ``` - ### Values with Parameters, Plurals A few of material translations contain `$variable` tokens. The @@ -101,7 +99,6 @@ MaterialLocalizations.of(context).aboutListTileTitle(yourAppTitle) The names of the `$variable` tokens must match the names of the `MaterialLocalizations` method parameters. - Plurals are handled similarly, with a lookup method that includes a quantity parameter. For example `selectedRowCountTitle` returns a string like "1 item selected" or "no items selected". @@ -149,18 +146,19 @@ section in the Material spec. The Material theme uses the `TextTheme`, see [Typography.geometryThemeFor](https://api.flutter.dev/flutter/material/Typography/geometryThemeFor.html). - -### 'generated_*_localizations.dart': all of the localizations +### 'generated\_\*\_localizations.dart': all of the localizations All of the localizations are combined in a single file per library using the gen_localizations script. You can see what that script would generate by running: + ```dart dart dev/tools/localization/bin/gen_localizations.dart ``` Actually update the generated files with: + ```dart dart dev/tools/localization/bin/gen_localizations.dart --overwrite ``` @@ -172,10 +170,10 @@ class implementations use these to lookup localized resource values. The gen_localizations script must be run by hand after .arb files have been updated. The script optionally takes parameters + 1. The path to this directory, 2. The file name prefix (the file name less the locale -suffix) for the .arb files in this directory. - + suffix) for the .arb files in this directory. ### Special handling for the Kannada (kn) translations @@ -211,8 +209,7 @@ Google contributes translations for all the languages supported by this package. (Googlers, for more details see .) If you have feedback about the translations please -[file an issue on the Flutter github repo](https://github.com/flutter/flutter/issues/new?template=2_bug.yml). - +[file an issue on the Flutter github repo](https://github.com/flutter/flutter/issues/new?template=02_bug.yml). ### See Also diff --git a/packages/flutter_tools/lib/src/cache.dart b/packages/flutter_tools/lib/src/cache.dart index 520e827abc..09f453a575 100644 --- a/packages/flutter_tools/lib/src/cache.dart +++ b/packages/flutter_tools/lib/src/cache.dart @@ -1244,7 +1244,7 @@ class ArtifactUpdater { status.pause(); _logger.printWarning( 'Downloading an artifact that may not be reachable in some environments (e.g. firewalled environments): $url\n' - 'This should not have happened. This is likely a Flutter SDK bug. Please file an issue at https://github.com/flutter/flutter/issues/new?template=1_activation.yml', + 'This should not have happened. This is likely a Flutter SDK bug. Please file an issue at https://github.com/flutter/flutter/issues/new?template=01_activation.yml', ); status.resume(); } diff --git a/packages/flutter_tools/lib/src/migrations/swift_package_manager_integration_migration.dart b/packages/flutter_tools/lib/src/migrations/swift_package_manager_integration_migration.dart index d8b250c24d..56c7d909de 100644 --- a/packages/flutter_tools/lib/src/migrations/swift_package_manager_integration_migration.dart +++ b/packages/flutter_tools/lib/src/migrations/swift_package_manager_integration_migration.dart @@ -179,7 +179,7 @@ class SwiftPackageManagerIntegrationMigration extends ProjectMigrator { 'An error occurred when adding Swift Package Manager integration:\n' ' $e\n\n' 'Swift Package Manager is currently an experimental feature, please file a bug at\n' - ' https://github.com/flutter/flutter/issues/new?template=1_activation.yml \n' + ' https://github.com/flutter/flutter/issues/new?template=01_activation.yml \n' 'Consider including a copy of the following files in your bug report:\n' ' ${_platform.name}/Runner.xcodeproj/project.pbxproj\n' ' ${_platform.name}/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme '