firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove obsolete work around for shadow drawing (#131066)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/130737.
This commit is contained in:
Michael Goderbauer 2023-07-21 15:59:01 -07:00 committed by GitHub
parent 99a4f7e1f9
commit 9a726e8542
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/flutter/lib/src/rendering/proxy_box.dart
View File

@ -1908,8 +1908,6 @@ abstract class _RenderPhysicalModelBase<T> extends _RenderCustomClip<T> {
} }
} }
final Paint _transparentPaint = Paint()..color = const Color(0x00000000);
/// Creates a physical model layer that clips its child to a rounded /// Creates a physical model layer that clips its child to a rounded
/// rectangle. /// rectangle.
/// ///
@ -2113,7 +2111,6 @@ class RenderPhysicalShape extends _RenderPhysicalModelBase<Path> {
} }
_updateClip(); _updateClip();
final Rect offsetBounds = offset & size;
final Path offsetPath = _clip!.shift(offset); final Path offsetPath = _clip!.shift(offset);
bool paintShadows = true; bool paintShadows = true;
assert(() { assert(() {
@ -2134,14 +2131,6 @@ class RenderPhysicalShape extends _RenderPhysicalModelBase<Path> {
final Canvas canvas = context.canvas; final Canvas canvas = context.canvas;
if (elevation != 0.0 && paintShadows) { if (elevation != 0.0 && paintShadows) {
// The drawShadow call doesn't add the region of the shadow to the
// picture's bounds, so we draw a hardcoded amount of extra space to
// account for the maximum potential area of the shadow.
// TODO(jsimmons): remove this when Skia does it for us.
canvas.drawRect(
offsetBounds.inflate(20.0),
_transparentPaint,
);
canvas.drawShadow( canvas.drawShadow(
offsetPath, offsetPath,
shadowColor, shadowColor,