firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Flutter tool assumes impeller is enabled by default (#156540)

Browse Source 
... because it is.
This commit is contained in:
John McDole 2024-10-10 11:44:18 -07:00 committed by GitHub
parent 6790525ce6
commit 9a9b9218ee
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter_tools/lib/src/project.dart
View File

@ -881,8 +881,7 @@ $javaGradleCompatUrl
return AndroidEmbeddingVersionResult(AndroidEmbeddingVersion.v1, 'No `<meta-data android:name="flutterEmbedding" android:value="2"/>` in ${appManifestFile.absolute.path}'); return AndroidEmbeddingVersionResult(AndroidEmbeddingVersion.v1, 'No `<meta-data android:name="flutterEmbedding" android:value="2"/>` in ${appManifestFile.absolute.path}');
} }
// TODO(matanlurey): Flip to true when on by default, https://github.com/flutter/flutter/issues/132712. static const bool _impellerEnabledByDefault = true;
static const bool _impellerEnabledByDefault = false;
/// Returns the `io.flutter.embedding.android.EnableImpeller` manifest value. /// Returns the `io.flutter.embedding.android.EnableImpeller` manifest value.
/// ///

4
packages/flutter_tools/test/commands.shard/permeable/build_aar_test.dart
View File

@ -330,7 +330,7 @@ void main() {
globals.fs.file(manifestPath).writeAsStringSync(newManifest); globals.fs.file(manifestPath).writeAsStringSync(newManifest);
} }
testUsingContext('a default AAR build reports Impeller as disabled', () async { testUsingContext('a default AAR build reports Impeller as enabled', () async {
final String projectPath = await createProject( final String projectPath = await createProject(
tempDir, tempDir,
arguments: <String>['--no-pub', '--template=module'] arguments: <String>['--no-pub', '--template=module']
@ -342,7 +342,7 @@ void main() {
fakeAnalytics.sentEvents, fakeAnalytics.sentEvents,
contains( contains(
Event.flutterBuildInfo( Event.flutterBuildInfo(
label: 'manifest-aar-impeller-disabled', label: 'manifest-aar-impeller-enabled',
buildType: 'android', buildType: 'android',
), ),
), ),

4
packages/flutter_tools/test/commands.shard/permeable/build_apk_test.dart
View File

@ -320,7 +320,7 @@ void main() {
globals.fs.file(manifestPath).writeAsStringSync(newManifest); globals.fs.file(manifestPath).writeAsStringSync(newManifest);
} }
testUsingContext('a default APK build reports Impeller as disabled', () async { testUsingContext('a default APK build reports Impeller as enabled', () async {
final String projectPath = await createProject( final String projectPath = await createProject(
tempDir, tempDir,
arguments: <String>['--no-pub', '--template=app', '--platform=android'] arguments: <String>['--no-pub', '--template=app', '--platform=android']
@ -332,7 +332,7 @@ void main() {
fakeAnalytics.sentEvents, fakeAnalytics.sentEvents,
contains( contains(
Event.flutterBuildInfo( Event.flutterBuildInfo(
label: 'manifest-impeller-disabled', label: 'manifest-impeller-enabled',
buildType: 'android', buildType: 'android',
), ),
), ),