firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remove unnecessary String.toString() (#81859)

Browse Source
This commit is contained in:
Alexandre Ardhuin 2021-05-07 23:54:02 +02:00 committed by GitHub
parent e74c15cac4
commit 9bca38c5e5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings.dart
View File

@ -66,7 +66,7 @@ import 'stock_strings_es.dart';
/// be consistent with the languages listed in the StockStrings.supportedLocales
/// property.
abstract class StockStrings {
StockStrings(String locale) : localeName = intl.Intl.canonicalizedLocale(locale.toString());
StockStrings(String locale) : localeName = intl.Intl.canonicalizedLocale(locale);
final String localeName;

2
dev/integration_tests/flutter_gallery/lib/demo/material/slider_demo.dart
View File

@ -282,7 +282,7 @@ class _SlidersState extends State<_Sliders> {
),
),
Slider.adaptive(
label: _continuousValue.toStringAsFixed(6).toString(),
label: _continuousValue.toStringAsFixed(6),
value: _continuousValue,
min: 0.0,
max: 100.0,

2
packages/flutter/lib/src/rendering/editable.dart
View File

@ -727,7 +727,7 @@ class RenderEditable extends RenderBox with RelayoutWhenSystemFontsChangeMixin {
int? lastNonWhitespace;
for (final String currentString in string.characters) {
if (!includeWhitespace &&
!_isWhitespace(currentString.characters.first.toString().codeUnitAt(0))) {
!_isWhitespace(currentString.characters.first.codeUnitAt(0))) {
lastNonWhitespace = count;
}
if (count + currentString.length >= index) {

2
packages/flutter_goldens_client/lib/skia_client.dart
View File

@ -376,7 +376,7 @@ class SkiaGoldClient {
/// Removes the file extension from the [fileName] to represent the test name
/// properly.
String cleanTestName(String fileName) {
return fileName.split(path.extension(fileName.toString()))[0];
return fileName.split(path.extension(fileName))[0];
}
/// Returns a boolean value to prevent the client from re-authorizing itself

2
packages/flutter_test/lib/src/_goldens_web.dart
View File

@ -64,7 +64,7 @@ class DefaultWebGoldenComparator extends WebGoldenComparator {
method: 'POST',
sendData: json.encode(<String, Object>{
'testUri': testUri.toString(),
'key': key.toString(),
'key': key,
'width': width.round(),
'height': height.round(),
}),

2
packages/flutter_tools/lib/src/android/gradle_utils.dart
View File

@ -235,7 +235,7 @@ void updateLocalProperties({
buildInfo.buildNumber ?? project.manifest.buildNumber,
globals.logger,
);
changeIfNecessary('flutter.versionCode', buildNumber?.toString());
changeIfNecessary('flutter.versionCode', buildNumber);
}
if (changed) {

2
packages/flutter_tools/lib/src/compile.dart
View File

@ -662,7 +662,7 @@ class DefaultResidentCompiler implements ResidentCompiler {
toMultiRootPath(fileUri, fileSystemScheme, fileSystemRoots, _platform.isWindows);
}
_server.stdin.writeln(message);
_logger.printTrace(message.toString());
_logger.printTrace(message);
}
_server.stdin.writeln(inputKey);
_logger.printTrace('<- $inputKey');

2
packages/flutter_tools/lib/src/ios/migrations/project_base_configuration_migration.dart
View File

@ -86,7 +86,7 @@ class ProjectBaseConfigurationMigration extends ProjectMigrator {
newProjectContents = newProjectContents.replaceAll(releaseBaseConfigurationOriginal, releaseBaseConfigurationReplacement);
if (originalProjectContents != newProjectContents) {
logger.printStatus('Project base configurations detected, removing.');
_xcodeProjectInfoFile.writeAsStringSync(newProjectContents.toString());
_xcodeProjectInfoFile.writeAsStringSync(newProjectContents);
}
return true;
}

2
packages/flutter_tools/lib/src/ios/simulators.dart
View File

@ -130,7 +130,7 @@ class SimControl {
return <String, Map<String, dynamic>>{};
}
try {
final Object decodeResult = json.decode(results.stdout?.toString())[section.name];
final Object decodeResult = json.decode(results.stdout)[section.name];
if (decodeResult is Map<String, dynamic>) {
return decodeResult;
}

2
packages/flutter_tools/lib/src/migrations/cmake_custom_command_migration.dart
View File

@ -70,7 +70,7 @@ class CmakeCustomCommandMigration extends ProjectMigrator {
}
if (originalProjectContents != newProjectContents) {
logger.printStatus('add_custom_command() missing VERBATIM or FLUTTER_TARGET_PLATFORM, updating.');
_cmakeFile.writeAsStringSync(newProjectContents.toString());
_cmakeFile.writeAsStringSync(newProjectContents);
}
return true;
}