From 9c7e2c25637edf51debfe54f2e720dcdb8b0ec50 Mon Sep 17 00:00:00 2001
From: Ben Konyi <bkonyi@google.com>
Date: Wed, 19 Feb 2025 17:53:35 -0500
Subject: [PATCH] [ Widget Preview ] Move `preview_detector_test.dart` from
 `general.shard` to `commands.shard` (#163619)

Tests under the `general.shard` have a 2000ms timeout and these tests
write to the real file system and watch directories for changes. This
can be slow on heavily loaded machines and cause flaky failures.
---
 .../hermetic}/widget_preview/preview_detector_test.dart  | 9 +++++++--
 .../{ => widget_preview}/widget_preview_test.dart        | 6 +++---
 2 files changed, 10 insertions(+), 5 deletions(-)
 rename packages/flutter_tools/test/{general.shard => commands.shard/hermetic}/widget_preview/preview_detector_test.dart (94%)
 rename packages/flutter_tools/test/commands.shard/hermetic/{ => widget_preview}/widget_preview_test.dart (98%)

diff --git a/packages/flutter_tools/test/general.shard/widget_preview/preview_detector_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/widget_preview/preview_detector_test.dart
similarity index 94%
rename from packages/flutter_tools/test/general.shard/widget_preview/preview_detector_test.dart
rename to packages/flutter_tools/test/commands.shard/hermetic/widget_preview/preview_detector_test.dart
index cf0b73e9f5..a7b8de089e 100644
--- a/packages/flutter_tools/test/general.shard/widget_preview/preview_detector_test.dart
+++ b/packages/flutter_tools/test/commands.shard/hermetic/widget_preview/preview_detector_test.dart
@@ -11,8 +11,13 @@ import 'package:flutter_tools/src/base/signals.dart';
 import 'package:flutter_tools/src/widget_preview/preview_detector.dart';
 import 'package:test/test.dart';
 
-import '../../src/common.dart';
-import '../../src/context.dart';
+import '../../../src/common.dart';
+import '../../../src/context.dart';
+
+// Note: this test isn't under the general.shard since tests under that directory
+// have a 2000ms time out and these tests write to the real file system and watch
+// directories for changes. This can be slow on heavily loaded machines and cause
+// flaky failures.
 
 Directory createBasicProjectStructure(FileSystem fs) {
   return fs.systemTempDirectory.createTempSync('root');
diff --git a/packages/flutter_tools/test/commands.shard/hermetic/widget_preview_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/widget_preview/widget_preview_test.dart
similarity index 98%
rename from packages/flutter_tools/test/commands.shard/hermetic/widget_preview_test.dart
rename to packages/flutter_tools/test/commands.shard/hermetic/widget_preview/widget_preview_test.dart
index 4c8c57b163..caa08069a0 100644
--- a/packages/flutter_tools/test/commands.shard/hermetic/widget_preview_test.dart
+++ b/packages/flutter_tools/test/commands.shard/hermetic/widget_preview/widget_preview_test.dart
@@ -16,9 +16,9 @@ import 'package:flutter_tools/src/project.dart';
 import 'package:test/test.dart';
 import 'package:test_api/fake.dart';
 
-import '../../src/common.dart';
-import '../../src/context.dart';
-import '../../src/fakes.dart';
+import '../../../src/common.dart';
+import '../../../src/context.dart';
+import '../../../src/fakes.dart';
 
 void main() {
   group('WidgetPreviewStartCommand', () {