firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use int for PlaceholderSpan.placeholderCodeUnit (#98971)

Browse Source
This commit is contained in:
Tomasz Gucio 2022-02-23 23:59:06 +01:00 committed by GitHub
parent c178cf859f
commit 9e7cc970ea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter/lib/src/painting/placeholder_span.dart
View File

@ -42,7 +42,7 @@ abstract class PlaceholderSpan extends InlineSpan {
}) : super(style: style); }) : super(style: style);
/// The unicode character to represent a placeholder. /// The unicode character to represent a placeholder.
static const String placeholderCodeUnit = '\uFFFC'; static const int placeholderCodeUnit = 0xFFFC;
/// How the placeholder aligns vertically with the text. /// How the placeholder aligns vertically with the text.
/// ///
@ -60,7 +60,7 @@ abstract class PlaceholderSpan extends InlineSpan {
@override @override
void computeToPlainText(StringBuffer buffer, {bool includeSemanticsLabels = true, bool includePlaceholders = true}) { void computeToPlainText(StringBuffer buffer, {bool includeSemanticsLabels = true, bool includePlaceholders = true}) {
if (includePlaceholders) { if (includePlaceholders) {
buffer.write(placeholderCodeUnit); buffer.writeCharCode(placeholderCodeUnit);
} }
} }

2
packages/flutter/lib/src/widgets/widget_span.dart
View File

@ -140,7 +140,7 @@ class WidgetSpan extends PlaceholderSpan {
@override @override
int? codeUnitAtVisitor(int index, Accumulator offset) { int? codeUnitAtVisitor(int index, Accumulator offset) {
offset.increment(1); offset.increment(1);
return PlaceholderSpan.placeholderCodeUnit.codeUnitAt(0); return PlaceholderSpan.placeholderCodeUnit;
} }
@override @override