firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add missing properties: ... and move to presubmit. (#162170)

Browse Source 
Closes https://github.com/flutter/flutter/issues/160701.

Resolves
https://github.com/flutter/flutter/issues/160701#issuecomment-2613078030
and moves to presubmit (which means this PR shouldn't be able to land
until it works).
This commit is contained in:
Matan Lurey 2025-01-27 16:29:28 -08:00 committed by GitHub
parent 95811bd82a
commit 9ebd172442
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 30 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
engine/src/flutter/.ci.yaml
View File

@ -459,7 +459,6 @@ targets:
- name: Linux mac_clang_tidy
recipe: engine_v2/engine_v2
bringup: true
properties:
config_name: mac_clang_tidy
runIf:
@ -477,26 +476,6 @@ targets:
# at https://github.com/flutter/flutter/issues/152186.
cores: "8"
- name: Mac mac_clang_tidy
recipe: engine_v2/engine_v2
timeout: 120
properties:
config_name: mac_clang_tidy
runIf:
- DEPS
- engine/src/flutter/.ci.yaml
- engine/src/flutter/tools/clang_tidy/**
- engine/src/flutter/ci/builders/**
- engine/src/flutter/ci/clang_tidy.sh
- "engine/src/flutter/**.h"
- "engine/src/flutter/**.c"
- "engine/src/flutter/**.cc"
- "engine/src/flutter/**.fbs"
- "engine/src/flutter/**.frag"
- "engine/src/flutter/**.vert"
- "engine/src/flutter/**.m"
- "engine/src/flutter/**.mm"
- name: Mac mac_host_engine
recipe: engine_v2/engine_v2
timeout: 240

35
engine/src/flutter/ci/builders/mac_clang_tidy.json
View File

@ -117,7 +117,12 @@
"max_attempts": 1,
"script": "flutter/ci/clang_tidy.sh"
}
]
],
"properties": {
"$flutter/osx_sdk": {
"sdk_version": "15a240d"
}
}
},
{
"name": "test: lint host_debug 1",
@ -167,7 +172,12 @@
"max_attempts": 1,
"script": "flutter/ci/clang_tidy.sh"
}
]
],
"properties": {
"$flutter/osx_sdk": {
"sdk_version": "15a240d"
}
}
},
{
"name": "test: lint host_debug 2",
@ -217,7 +227,12 @@
"max_attempts": 1,
"script": "flutter/ci/clang_tidy.sh"
}
]
],
"properties": {
"$flutter/osx_sdk": {
"sdk_version": "15a240d"
}
}
},
{
"name": "test: lint host_debug 3",
@ -267,7 +282,12 @@
"max_attempts": 1,
"script": "flutter/ci/clang_tidy.sh"
}
]
],
"properties": {
"$flutter/osx_sdk": {
"sdk_version": "15a240d"
}
}
},
{
"name": "test: lint ios_debug_sim",
@ -335,7 +355,12 @@
"max_attempts": 1,
"script": "flutter/ci/clang_tidy.sh"
}
]
],
"properties": {
"$flutter/osx_sdk": {
"sdk_version": "15a240d"
}
}
}
]
}