firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

use PDI to end the isolated scope for RLI (#141345)

Browse Source 
will fix https://github.com/flutter/flutter/issues/141344

https://unicode.org/reports/tr9/#Explicit_Directional_Isolates
https://api.flutter.dev/flutter/foundation/Unicode/RLI-constant.html
This commit is contained in:
Kohei Seino 2024-01-31 08:16:01 +09:00 committed by GitHub
parent abebd340d7
commit 9ed650aee5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/widgets/semantics_debugger.dart
View File

@ -318,7 +318,7 @@ class _SemanticsDebuggerPainter extends CustomPainter {
} else {
switch (data.textDirection!) {
case TextDirection.rtl:
effectivelabel = '${Unicode.RLI}$tooltipAndLabel${Unicode.PDF}';
effectivelabel = '${Unicode.RLI}$tooltipAndLabel${Unicode.PDI}';
case TextDirection.ltr:
effectivelabel = tooltipAndLabel;
}

21
packages/flutter/test/widgets/semantics_debugger_test.dart
View File

@ -524,6 +524,27 @@ void main() {
// ignore: avoid_dynamic_calls
expect(_getSemanticsDebuggerPainter(debuggerKey: debugger, tester: tester).labelStyle, labelStyle);
});
testWidgets('SemanticsDebugger label for rtl.', (WidgetTester tester) async {
final UniqueKey debugger = UniqueKey();
final Key label = UniqueKey();
await tester.pumpWidget(
Directionality(
textDirection: TextDirection.rtl,
child: SemanticsDebugger(
key: debugger,
child: Semantics(
label: 'ملصق',
textDirection: TextDirection.rtl,
key: label,
),
),
),
);
expect(_getMessageShownInSemanticsDebugger(widgetKey: label, debuggerKey: debugger, tester: tester), '\u2067ملصق\u2069');
});
}
String _getMessageShownInSemanticsDebugger({