From 9f92f7928e849ae7cd9cfddac5909bf896c823e7 Mon Sep 17 00:00:00 2001
From: Chris Bracken <chris@bracken.jp>
Date: Wed, 1 Mar 2017 11:18:43 -0800
Subject: [PATCH] Add tests for ScrollController assertions (#8499)

Ensure that read and write operations fail on ScrollControllers
associated with a number of positions other than 1.
---
 .../test/widgets/scroll_controller_test.dart  | 69 +++++++++++++++++++
 1 file changed, 69 insertions(+)

diff --git a/packages/flutter/test/widgets/scroll_controller_test.dart b/packages/flutter/test/widgets/scroll_controller_test.dart
index 1533abd7a3..29b6f336be 100644
--- a/packages/flutter/test/widgets/scroll_controller_test.dart
+++ b/packages/flutter/test/widgets/scroll_controller_test.dart
@@ -160,4 +160,73 @@ void main() {
     await tester.pumpWidget(new Container(), const Duration(seconds: 2));
   });
 
+  testWidgets('Read operations on ScrollControllers with no positions fail', (WidgetTester tester) async {
+    ScrollController controller = new ScrollController();
+    expect(() => controller.offset, throwsAssertionError);
+    expect(() => controller.position, throwsAssertionError);
+  });
+
+  testWidgets('Read operations on ScrollControllers with more than one position fail', (WidgetTester tester) async {
+    ScrollController controller = new ScrollController();
+    await tester.pumpWidget(new ListView(
+      children: <Widget>[
+        new Container(
+          constraints: const BoxConstraints(maxHeight: 500.0),
+          child: new ListView(
+            controller: controller,
+            children: kStates.map<Widget>((String state) {
+              return new Container(height: 200.0, child: new Text(state));
+            }).toList(),
+          ),
+        ),
+        new Container(
+          constraints: const BoxConstraints(maxHeight: 500.0),
+          child: new ListView(
+            controller: controller,
+            children: kStates.map<Widget>((String state) {
+              return new Container(height: 200.0, child: new Text(state));
+            }).toList(),
+          ),
+        ),
+      ],
+    ));
+
+    expect(() => controller.offset, throwsAssertionError);
+    expect(() => controller.position, throwsAssertionError);
+  });
+
+  testWidgets('Write operations on ScrollControllers with no positions fail', (WidgetTester tester) async {
+    ScrollController controller = new ScrollController();
+    expect(() => controller.animateTo(1.0, duration: const Duration(seconds: 1), curve: Curves.linear), throwsAssertionError);
+    expect(() => controller.jumpTo(1.0), throwsAssertionError);
+  });
+
+  testWidgets('Write operations on ScrollControllers with more than one position fail', (WidgetTester tester) async {
+    ScrollController controller = new ScrollController();
+    await tester.pumpWidget(new ListView(
+      children: <Widget>[
+        new Container(
+          constraints: const BoxConstraints(maxHeight: 500.0),
+          child: new ListView(
+            controller: controller,
+            children: kStates.map<Widget>((String state) {
+              return new Container(height: 200.0, child: new Text(state));
+            }).toList(),
+          ),
+        ),
+        new Container(
+          constraints: const BoxConstraints(maxHeight: 500.0),
+          child: new ListView(
+            controller: controller,
+            children: kStates.map<Widget>((String state) {
+              return new Container(height: 200.0, child: new Text(state));
+            }).toList(),
+          ),
+        ),
+      ],
+    ));
+
+    expect(() => controller.jumpTo(1.0), throwsAssertionError);
+    expect(() => controller.animateTo(1.0, duration: const Duration(seconds: 1), curve: Curves.linear), throwsAssertionError);
+  });
 }