firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update the timeouts since tests time out after 15 minutes not 30 seconds. (#88061)

Browse Source
This commit is contained in:
Ian Hickson 2021-08-20 12:52:03 -07:00 committed by GitHub
parent d5d8265079
commit 9f9aa46b7d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/flutter_tools/test/integration.shard/overall_experience_test.dart
View File

@ -189,7 +189,7 @@ Future<ProcessTestResult> runFlutter(
List<Transition> transitions, { List<Transition> transitions, {
bool debug = false, bool debug = false,
bool logging = true, bool logging = true,
Duration expectedMaxDuration = const Duration(seconds: 25), // must be less than test timeout of 30 seconds! Duration expectedMaxDuration = const Duration(minutes: 10), // must be less than test timeout of 15 minutes!
}) async { }) async {
final Stopwatch clock = Stopwatch()..start(); final Stopwatch clock = Stopwatch()..start();
final Process process = await processManager.start( final Process process = await processManager.start(
@ -271,7 +271,7 @@ Future<ProcessTestResult> runFlutter(
} }
nextTransition += 1; nextTransition += 1;
timeout?.cancel(); timeout?.cancel();
timeout = Timer(expectedMaxDuration ~/ 5, processTimeout); timeout = Timer(expectedMaxDuration ~/ 5, processTimeout); // This is not a failure timeout, just when to start logging verbosely to help debugging.
} }
} }
void processStderr(String line) { void processStderr(String line) {
@ -284,11 +284,11 @@ Future<ProcessTestResult> runFlutter(
if (debug) { if (debug) {
processTimeout(); processTimeout();
} else { } else {
timeout = Timer(expectedMaxDuration ~/ 2, processTimeout); timeout = Timer(expectedMaxDuration ~/ 2, processTimeout); // This is not a failure timeout, just when to start logging verbosely to help debugging.
} }
process.stdout.transform<String>(utf8.decoder).transform<String>(const LineSplitter()).listen(processStdout); process.stdout.transform<String>(utf8.decoder).transform<String>(const LineSplitter()).listen(processStdout);
process.stderr.transform<String>(utf8.decoder).transform<String>(const LineSplitter()).listen(processStderr); process.stderr.transform<String>(utf8.decoder).transform<String>(const LineSplitter()).listen(processStderr);
unawaited(process.exitCode.timeout(expectedMaxDuration, onTimeout: () { unawaited(process.exitCode.timeout(expectedMaxDuration, onTimeout: () { // This is a failure timeout, must not be short.
print('${stamp()} (process is not quitting, trying to send a "q" just in case that helps)'); print('${stamp()} (process is not quitting, trying to send a "q" just in case that helps)');
print('(a functional test should never reach this point)'); print('(a functional test should never reach this point)');
final LogLine inLog = LogLine('stdin', stamp(), 'q'); final LogLine inLog = LogLine('stdin', stamp(), 'q');
@ -298,7 +298,7 @@ Future<ProcessTestResult> runFlutter(
} }
process.stdin.write('q'); process.stdin.write('q');
return -1; // discarded return -1; // discarded
}).catchError((Object error) { /* ignore the error here, it'll be reported on the next line */ })); }).catchError((Object error) { /* ignore errors here, they will be reported on the next line */ }));
final int exitCode = await process.exitCode; final int exitCode = await process.exitCode;
if (streamingLogs) { if (streamingLogs) {
print('${stamp()} (process terminated with exit code $exitCode)'); print('${stamp()} (process terminated with exit code $exitCode)');