firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Android] add missing null check to java object for hcpp mode. (#163165)

Browse Source 
This can be hit if the FlutterJNI has been disconnected. In this case,
it is correct to return a nullptr as the engine can create its own
trasnaction.
This commit is contained in:
Jonah Williams 2025-02-12 16:58:48 -08:00 committed by GitHub
parent 1c0a76d031
commit a0dca0c30a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
engine/src/flutter/shell/platform/android/platform_view_android_jni_impl.cc
View File

@ -2023,16 +2023,18 @@ ASurfaceTransaction* PlatformViewAndroidJNIImpl::createTransaction() {
JNIEnv* env = fml::jni::AttachCurrentThread();
auto java_object = java_object_.get(env);
if (java_object.is_null()) {
return nullptr;
}
fml::jni::ScopedJavaLocalRef<jobject> transaction(
env,
env->CallObjectMethod(java_object.obj(), g_create_transaction_method));
if (transaction.is_null()) {
return nullptr;
}
FML_CHECK(fml::jni::CheckException(env));
return impeller::android::GetProcTable().ASurfaceTransaction_fromJava(
env, transaction.obj());
}