diff --git a/packages/flutter/lib/src/rendering/flex.dart b/packages/flutter/lib/src/rendering/flex.dart index 47588e449a..4101a690f4 100644 --- a/packages/flutter/lib/src/rendering/flex.dart +++ b/packages/flutter/lib/src/rendering/flex.dart @@ -971,6 +971,10 @@ class RenderFlex extends RenderBox with ContainerRenderObjectMixin[ + const SizedBox(width: 200.0, height: 200.0), + ], + ), + ), + ); + + expect(find.byType(Column), isNot(paints..rect())); + + await tester.pumpWidget( + new Center( + child: new SizedBox( + height: 100.0, + child: new Column( + children: [ + const SizedBox(width: 200.0, height: 200.0), + ], + ), + ), + ), + ); + + expect(tester.takeException(), isNotNull); + + expect(find.byType(Column), paints..rect()); + + await tester.pumpWidget( + new Center( + child: new SizedBox( + height: 0.0, + child: new Column( + children: [ + const SizedBox(width: 200.0, height: 200.0), + ], + ), + ), + ), + ); + + expect(find.byType(Column), isNot(paints..rect())); + }); +} diff --git a/packages/flutter/test/widgets/column_test.dart b/packages/flutter/test/widgets/column_test.dart index af2d39e82b..bfe832bdf8 100644 --- a/packages/flutter/test/widgets/column_test.dart +++ b/packages/flutter/test/widgets/column_test.dart @@ -384,8 +384,6 @@ void main() { ) )); - expect(tester.takeException(), contains('overflowed')); - final RenderBox renderBox = tester.renderObject(find.byKey(childKey)); expect(renderBox.size.width, equals(0.0)); expect(renderBox.size.height, equals(100.0)); @@ -779,8 +777,6 @@ void main() { ) )); - expect(tester.takeException(), contains('overflowed')); - final RenderBox renderBox = tester.renderObject(find.byKey(childKey)); expect(renderBox.size.width, equals(0.0)); expect(renderBox.size.height, equals(100.0)); diff --git a/packages/flutter/test/widgets/row_test.dart b/packages/flutter/test/widgets/row_test.dart index 7b52a5020f..1220e5d58d 100644 --- a/packages/flutter/test/widgets/row_test.dart +++ b/packages/flutter/test/widgets/row_test.dart @@ -302,8 +302,6 @@ void main() { ), )); - expect(tester.takeException(), contains('overflowed')); - final RenderBox renderBox = tester.renderObject(find.byKey(childKey)); expect(renderBox.size.width, equals(100.0)); expect(renderBox.size.height, equals(0.0)); @@ -727,8 +725,6 @@ void main() { ), )); - expect(tester.takeException(), contains('overflowed')); - final RenderBox renderBox = tester.renderObject(find.byKey(childKey)); expect(renderBox.size.width, equals(100.0)); expect(renderBox.size.height, equals(0.0)); @@ -1152,8 +1148,6 @@ void main() { ), )); - expect(tester.takeException(), contains('overflowed')); - final RenderBox renderBox = tester.renderObject(find.byKey(childKey)); expect(renderBox.size.width, equals(100.0)); expect(renderBox.size.height, equals(0.0));