firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Impeller] move barrier setting out of render pass builder. (#160693)

Browse Source 
Refactoring to make sure that we're always tracking the correct layout
state.
This commit is contained in:
Jonah Williams 2024-12-20 21:15:21 -08:00 committed by GitHub
parent 4431c09f55
commit a17c647ccc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
engine/src/flutter/impeller/renderer/backend/vulkan/render_pass_vk.cc
View File

@ -24,8 +24,6 @@
#include "impeller/renderer/backend/vulkan/sampler_vk.h"
#include "impeller/renderer/backend/vulkan/shared_object_vk.h"
#include "impeller/renderer/backend/vulkan/texture_vk.h"
#include "vulkan/vulkan.hpp"
#include "vulkan/vulkan_handles.hpp"
namespace impeller {
@ -91,15 +89,8 @@ SharedHandleVK<vk::RenderPass> RenderPassVK::CreateVKRenderPass(
attachment.texture->GetTextureDescriptor().format, //
attachment.texture->GetTextureDescriptor().sample_count, //
attachment.load_action, //
attachment.store_action, //
TextureVK::Cast(*attachment.texture).GetLayout() //
attachment.store_action //
);
TextureVK::Cast(*attachment.texture)
.SetLayoutWithoutEncoding(vk::ImageLayout::eGeneral);
if (attachment.resolve_texture) {
TextureVK::Cast(*attachment.resolve_texture)
.SetLayoutWithoutEncoding(vk::ImageLayout::eGeneral);
}
return true;
});
@ -204,6 +195,15 @@ RenderPassVK::RenderPassVK(const std::shared_ptr<const Context>& context,
command_buffer_vk_.beginRenderPass(pass_info, vk::SubpassContents::eInline);
if (resolve_image_vk_) {
TextureVK::Cast(*resolve_image_vk_)
.SetLayoutWithoutEncoding(vk::ImageLayout::eGeneral);
}
if (color_image_vk_) {
TextureVK::Cast(*color_image_vk_)
.SetLayoutWithoutEncoding(vk::ImageLayout::eGeneral);
}
// Set the initial viewport.
const auto vp = Viewport{.rect = Rect::MakeSize(target_size)};
vk::Viewport viewport = vk::Viewport()

1
engine/src/flutter/impeller/renderer/backend/vulkan/render_pass_vk.h
View File

@ -12,7 +12,6 @@
#include "impeller/renderer/command_buffer.h"
#include "impeller/renderer/render_pass.h"
#include "impeller/renderer/render_target.h"
#include "vulkan/vulkan_handles.hpp"
namespace impeller {