diff --git a/examples/fitness/lib/feed.dart b/examples/fitness/lib/feed.dart index 4c68f073b5..9982d107f8 100644 --- a/examples/fitness/lib/feed.dart +++ b/examples/fitness/lib/feed.dart @@ -14,7 +14,7 @@ class FitnessItemList extends StatelessComponent { final FitnessItemHandler onDismissed; Widget build(BuildContext context) { - return new ScrollableList2( + return new ScrollableList( padding: const EdgeDims.all(4.0), itemExtent: kFitnessItemHeight, children: items.map((FitnessItem item) => item.toRow(onDismissed: onDismissed)) diff --git a/examples/stocks/lib/stock_list.dart b/examples/stocks/lib/stock_list.dart index 4f116992a3..19fae3e599 100644 --- a/examples/stocks/lib/stock_list.dart +++ b/examples/stocks/lib/stock_list.dart @@ -14,7 +14,7 @@ class StockList extends StatelessComponent { final StockRowActionCallback onAction; Widget build(BuildContext context) { - return new ScrollableList2( + return new ScrollableList( itemExtent: StockRow.kHeight, children: stocks.map((Stock stock) { return new StockRow( diff --git a/examples/widgets/card_collection.dart b/examples/widgets/card_collection.dart index 4e182b8689..a33a70ae53 100644 --- a/examples/widgets/card_collection.dart +++ b/examples/widgets/card_collection.dart @@ -393,7 +393,7 @@ class CardCollectionState extends State { Widget build(BuildContext context) { Widget cardCollection; if (_fixedSizeCards) { - cardCollection = new ScrollableList2 ( + cardCollection = new ScrollableList ( snapOffsetCallback: _snapToCenter ? _toSnapOffset : null, snapAlignmentOffset: _cardCollectionSize.height / 2.0, itemExtent: _cardModels[0].height, diff --git a/examples/widgets/media_query.dart b/examples/widgets/media_query.dart index a3ee4c0b2a..cfa0c8da29 100644 --- a/examples/widgets/media_query.dart +++ b/examples/widgets/media_query.dart @@ -72,7 +72,7 @@ class MediaQueryExample extends StatelessComponent { items.add(new AdaptiveItem("Item $i")); if (MediaQuery.of(context).size.width < _gridViewBreakpoint) { - return new ScrollableList2( + return new ScrollableList( itemExtent: 50.0, children: items.map((AdaptiveItem item) => item.toListItem()) ); diff --git a/examples/widgets/scrollbar.dart b/examples/widgets/scrollbar.dart index 03422c9614..50bdc26e51 100644 --- a/examples/widgets/scrollbar.dart +++ b/examples/widgets/scrollbar.dart @@ -30,7 +30,7 @@ class ScrollbarAppState extends State { final ScrollbarPainter _scrollbarPainter = new ScrollbarPainter(); Widget _buildMenu(BuildContext context) { - return new ScrollableList2( + return new ScrollableList( itemExtent: _itemExtent, scrollableListPainter: _scrollbarPainter, children: new List.generate(_itemCount, (int i) => new _Item(i)) diff --git a/packages/flutter/lib/src/material/material_list.dart b/packages/flutter/lib/src/material/material_list.dart index da4a2c1762..2f2532f595 100644 --- a/packages/flutter/lib/src/material/material_list.dart +++ b/packages/flutter/lib/src/material/material_list.dart @@ -42,7 +42,7 @@ class _MaterialListState extends State { ScrollbarPainter _scrollbarPainter = new ScrollbarPainter(); Widget build(BuildContext context) { - return new ScrollableList2( + return new ScrollableList( initialScrollOffset: config.initialScrollOffset, scrollDirection: ScrollDirection.vertical, onScroll: config.onScroll, diff --git a/packages/flutter/lib/src/widgets/scrollable.dart b/packages/flutter/lib/src/widgets/scrollable.dart index 460248ed17..2af0e69f86 100644 --- a/packages/flutter/lib/src/widgets/scrollable.dart +++ b/packages/flutter/lib/src/widgets/scrollable.dart @@ -666,59 +666,6 @@ abstract class ScrollableWidgetListState extends typedef Widget ItemBuilder(BuildContext context, T item, int index); -/// A wrapper around [ScrollableWidgetList] that helps you translate a list of -/// model objects into a scrollable list of widgets. Assumes all the widgets -/// have the same height. -class ScrollableList extends ScrollableWidgetList { - ScrollableList({ - Key key, - double initialScrollOffset, - ScrollDirection scrollDirection: ScrollDirection.vertical, - ScrollListener onScroll, - SnapOffsetCallback snapOffsetCallback, - double snapAlignmentOffset: 0.0, - this.items, - this.itemBuilder, - bool itemsWrap: false, - double itemExtent, - EdgeDims padding, - ScrollableListPainter scrollableListPainter - }) : super( - key: key, - initialScrollOffset: initialScrollOffset, - scrollDirection: scrollDirection, - onScroll: onScroll, - snapOffsetCallback: snapOffsetCallback, - snapAlignmentOffset: snapAlignmentOffset, - itemsWrap: itemsWrap, - itemExtent: itemExtent, - padding: padding, - scrollableListPainter: scrollableListPainter - ); - - final List items; - final ItemBuilder itemBuilder; - - ScrollableListState> createState() => new ScrollableListState>(); -} - -class ScrollableListState> extends ScrollableWidgetListState { - ScrollBehavior createScrollBehavior() { - return config.itemsWrap ? new UnboundedBehavior() : super.createScrollBehavior(); - } - - int get itemCount => config.items.length; - - List buildItems(BuildContext context, int start, int count) { - List result = new List(); - int begin = config.itemsWrap ? start : math.max(0, start); - int end = config.itemsWrap ? begin + count : math.min(begin + count, config.items.length); - for (int i = begin; i < end; ++i) - result.add(config.itemBuilder(context, config.items[i % itemCount], i)); - return result; - } -} - /// A general scrollable list for a large number of children that might not all /// have the same height. Prefer [ScrollableWidgetList] when all the children /// have the same height because it can use that property to be more efficient. diff --git a/packages/flutter/lib/src/widgets/scrollable_list.dart b/packages/flutter/lib/src/widgets/scrollable_list.dart index 36d7ab25d2..56e12e6611 100644 --- a/packages/flutter/lib/src/widgets/scrollable_list.dart +++ b/packages/flutter/lib/src/widgets/scrollable_list.dart @@ -11,8 +11,8 @@ import 'virtual_viewport.dart'; import 'package:flutter/animation.dart'; import 'package:flutter/rendering.dart'; -class ScrollableList2 extends Scrollable { - ScrollableList2({ +class ScrollableList extends Scrollable { + ScrollableList({ Key key, double initialScrollOffset, ScrollDirection scrollDirection: ScrollDirection.vertical, @@ -44,7 +44,7 @@ class ScrollableList2 extends Scrollable { ScrollableState createState() => new _ScrollableList2State(); } -class _ScrollableList2State extends ScrollableState { +class _ScrollableList2State extends ScrollableState { ScrollBehavior createScrollBehavior() => new OverscrollBehavior(); ExtentScrollBehavior get scrollBehavior => super.scrollBehavior; diff --git a/packages/flutter/test/widget/dismissable_test.dart b/packages/flutter/test/widget/dismissable_test.dart index da6a6ebbd8..5179694bec 100644 --- a/packages/flutter/test/widget/dismissable_test.dart +++ b/packages/flutter/test/widget/dismissable_test.dart @@ -38,7 +38,7 @@ Widget buildDismissableItem(int item) { Widget widgetBuilder() { return new Container( padding: const EdgeDims.all(10.0), - child: new ScrollableList2( + child: new ScrollableList( scrollDirection: scrollDirection, itemExtent: itemExtent, children: [0, 1, 2, 3, 4].where( diff --git a/packages/flutter/test/widget/reparent_state_test.dart b/packages/flutter/test/widget/reparent_state_test.dart index 665e58b4be..b7e48159ef 100644 --- a/packages/flutter/test/widget/reparent_state_test.dart +++ b/packages/flutter/test/widget/reparent_state_test.dart @@ -99,7 +99,7 @@ void main() { (key.currentState as StateMarkerState).marker = "marked"; - tester.pumpWidget(new ScrollableList2( + tester.pumpWidget(new ScrollableList( itemExtent: 100.0, children: [ new Container( diff --git a/packages/flutter/test/widget/scrollable_list_hit_testing_test.dart b/packages/flutter/test/widget/scrollable_list_hit_testing_test.dart index e9a3530af6..020b24d1c4 100644 --- a/packages/flutter/test/widget/scrollable_list_hit_testing_test.dart +++ b/packages/flutter/test/widget/scrollable_list_hit_testing_test.dart @@ -17,7 +17,7 @@ void main() { tester.pumpWidget(new Center( child: new Container( height: 50.0, - child: new ScrollableList2( + child: new ScrollableList( key: new GlobalKey(), itemExtent: 290.0, scrollDirection: ScrollDirection.horizontal, @@ -57,7 +57,7 @@ void main() { tester.pumpWidget(new Center( child: new Container( width: 50.0, - child: new ScrollableList2( + child: new ScrollableList( key: new GlobalKey(), itemExtent: 290.0, scrollDirection: ScrollDirection.vertical, diff --git a/packages/flutter/test/widget/scrollable_list_horizontal_test.dart b/packages/flutter/test/widget/scrollable_list_horizontal_test.dart index 519c16dda1..1ba84b1dd5 100644 --- a/packages/flutter/test/widget/scrollable_list_horizontal_test.dart +++ b/packages/flutter/test/widget/scrollable_list_horizontal_test.dart @@ -13,7 +13,7 @@ Widget buildFrame() { return new Center( child: new Container( height: 50.0, - child: new ScrollableList2( + child: new ScrollableList( itemExtent: 290.0, scrollDirection: ScrollDirection.horizontal, children: items.map((int item) { diff --git a/packages/flutter/test/widget/scrollable_list_vertical_test.dart b/packages/flutter/test/widget/scrollable_list_vertical_test.dart index 95afb1557c..366dbe6de7 100644 --- a/packages/flutter/test/widget/scrollable_list_vertical_test.dart +++ b/packages/flutter/test/widget/scrollable_list_vertical_test.dart @@ -9,7 +9,7 @@ import 'package:test/test.dart'; const List items = const [0, 1, 2, 3, 4, 5]; Widget buildFrame() { - return new ScrollableList2( + return new ScrollableList( itemExtent: 290.0, scrollDirection: ScrollDirection.vertical, children: items.map((int item) { diff --git a/packages/flutter/test/widget/snap_scrolling_test.dart b/packages/flutter/test/widget/snap_scrolling_test.dart index 94069ca2c0..629b51f5e9 100644 --- a/packages/flutter/test/widget/snap_scrolling_test.dart +++ b/packages/flutter/test/widget/snap_scrolling_test.dart @@ -29,7 +29,7 @@ Widget buildFrame() { return new Center( child: new Container( height: itemExtent * 2.0, - child: new ScrollableList2( + child: new ScrollableList( key: scrollableListKey, snapOffsetCallback: snapOffsetCallback, scrollDirection: scrollDirection,