firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Keep indeterminate RefreshProgressIndicator spinning until end of time (#18010)

Browse Source
This commit is contained in:
Michael Goderbauer 2018-05-29 18:04:13 -07:00 committed by GitHub
parent 921695cc44
commit a2d1d27f79
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter/lib/src/material/progress_indicator.dart
View File

@ -528,8 +528,8 @@ class _RefreshProgressIndicatorState extends _CircularProgressIndicatorState {
Widget build(BuildContext context) {
if (widget.value != null)
_controller.value = widget.value / 10.0;
else
_controller.forward();
else if (!_controller.isAnimating)
_controller.repeat();
return _buildAnimation();
}

26
packages/flutter/test/material/progress_indicator_test.dart
View File

@ -206,4 +206,30 @@ void main() {
expect(find.byType(CircularProgressIndicator), paints..arc(strokeWidth: 16.0));
});
testWidgets('Indeterminate RefreshProgressIndicator keeps spinning until end of time (approximate)', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/13782
await tester.pumpWidget(
const Directionality(
textDirection: TextDirection.ltr,
child: const Center(
child: const SizedBox(
width: 200.0,
child: const RefreshProgressIndicator(),
),
),
),
);
expect(tester.hasRunningAnimations, isTrue);
await tester.pump(const Duration(milliseconds: 6666));
expect(tester.hasRunningAnimations, isTrue);
await tester.pump(const Duration(milliseconds: 1));
expect(tester.hasRunningAnimations, isTrue);
await tester.pump(const Duration(days: 9999));
expect(tester.hasRunningAnimations, isTrue);
});
}