firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Resurrect spinning_mixed.

Browse Source 
It had bit-rotted. Also improve our error reporting for missing Material.
This commit is contained in:
Hixie 2016-01-15 16:38:10 -08:00
parent b5470df8d7
commit a309cea1d4
2 changed files with 32 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
examples/widgets/spinning_mixed.dart
View File

@ -40,10 +40,10 @@ void attachWidgetTreeToRenderTree(RenderProxyBox container) {
child: new Column( child: new Column(
children: <Widget>[ children: <Widget>[
new Rectangle(const Color(0xFF00FFFF)), new Rectangle(const Color(0xFF00FFFF)),
new Container( new Material(
child: new Container(
padding: new EdgeDims.all(10.0), padding: new EdgeDims.all(10.0),
margin: new EdgeDims.all(10.0), margin: new EdgeDims.all(10.0),
decoration: new BoxDecoration(backgroundColor: const Color(0xFFCCCCCC)),
child: new Row( child: new Row(
children: <Widget>[ children: <Widget>[
new RaisedButton( new RaisedButton(
@ -62,6 +62,7 @@ void attachWidgetTreeToRenderTree(RenderProxyBox container) {
], ],
justifyContent: FlexJustifyContent.spaceAround justifyContent: FlexJustifyContent.spaceAround
) )
)
), ),
new Rectangle(const Color(0xFFFFFF00)), new Rectangle(const Color(0xFFFFFF00)),
], ],
@ -86,6 +87,7 @@ void rotate(Duration timeStamp) {
} }
void main() { void main() {
WidgetFlutterBinding.ensureInitialized();
RenderProxyBox proxy = new RenderProxyBox(); RenderProxyBox proxy = new RenderProxyBox();
attachWidgetTreeToRenderTree(proxy); attachWidgetTreeToRenderTree(proxy);
@ -97,7 +99,6 @@ void main() {
transformBox = new RenderTransform(child: flexRoot, transform: new Matrix4.identity()); transformBox = new RenderTransform(child: flexRoot, transform: new Matrix4.identity());
RenderPadding root = new RenderPadding(padding: new EdgeDims.all(80.0), child: transformBox); RenderPadding root = new RenderPadding(padding: new EdgeDims.all(80.0), child: transformBox);
WidgetFlutterBinding.ensureInitialized() WidgetFlutterBinding.instance.renderView.child = root;
..renderView.child = root WidgetFlutterBinding.instance.addPersistentFrameCallback(rotate);
..addPersistentFrameCallback(rotate);
} }

11
packages/flutter/lib/src/material/debug.dart
View File

@ -8,11 +8,14 @@ import 'material.dart';
bool debugCheckHasMaterial(BuildContext context) { bool debugCheckHasMaterial(BuildContext context) {
assert(() { assert(() {
if (context.widget is Material || context.ancestorWidgetOfExactType(Material) != null) if (context.widget is! Material && context.ancestorWidgetOfExactType(Material) == null) {
return true;
Element element = context; Element element = context;
debugPrint('${context.widget} needs to be placed inside a Material widget. Ownership chain:\n${element.debugGetOwnershipChain(10)}'); throw new WidgetError(
return false; 'Missing Material widget.',
'${context.widget} needs to be placed inside a Material widget. Ownership chain:\n${element.debugGetOwnershipChain(10)}'
);
}
return true;
}); });
return true; return true;
} }