firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[web] ignore pointer events on plain text spans (flutter/engine#53694)

Browse Source 
A semantic node may be tappable without having a more concrete role set on it, such as "button". It will just have a tap handler. This could lead to the sized span to be chosen as the label representation. However, when pointer events land on the span the DOM `target` becomes the span rather than the tappable element, and that breaks the debouncing logic in `pointer_binding.dart`.

This PR removes pointer event handling from inert text spans. This fixes the click debounce logic.

Fixes https://github.com/flutter/flutter/issues/151265
This commit is contained in:
Yegor 2024-07-03 15:00:05 -07:00 committed by GitHub
parent 5fb88851d5
commit a314952184
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
engine/src/flutter/lib/web_ui/lib/src/engine/semantics/label_and_value.dart
View File

@ -248,7 +248,15 @@ final class SizedSpanRepresentation extends LabelRepresentationBehavior {
// The origin of the coordinate system is the top-left corner of the // The origin of the coordinate system is the top-left corner of the
// parent element. // parent element.
..transformOrigin = '0 0 0'; ..transformOrigin = '0 0 0'
// The node may be tappable without having a more concrete role set on it,
// such as "button". It will just have a tap handler. This could lead to
// sized span to be chosen as the label representation strategy. However,
// when pointer events land on the span the DOM `target` becomes the span
// rather than the tappable element, and that breaks the debouncing logic
// in `pointer_binding.dart`.
..pointerEvents = 'none';
semanticsObject.element.appendChild(_domText); semanticsObject.element.appendChild(_domText);
} }

23
engine/src/flutter/lib/web_ui/test/engine/semantics/semantics_text_test.dart
View File

@ -285,4 +285,27 @@ Future<void> testMain() async {
semantics().semanticsEnabled = false; semantics().semanticsEnabled = false;
}); });
test('The <span> ignores pointer events', () async {
semantics()
..debugOverrideTimestampFunction(() => _testTime)
..semanticsEnabled = true;
final SemanticsTester tester = SemanticsTester(owner());
tester.updateNode(
id: 0,
label: 'Ignore pointer events',
transform: Matrix4.identity().toFloat64(),
rect: const ui.Rect.fromLTRB(0, 0, 100, 50),
);
tester.apply();
expectSemanticsTree(owner(), '''
<sem>
<span style="pointer-events: none">Ignore pointer events</span>
</sem>'''
);
semantics().semanticsEnabled = false;
});
} }