firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[web] Move frame_reference.dart to the html/ folder (#162608)

Browse Source 
The `frame_reference.dart` file is only used by the HTML renderer. I'm
moving the file to the `html/` folder so that we don't forget to delete
with the rest of the HTML renderer code.
This commit is contained in:
Mouad Debbar 2025-02-07 13:35:43 -05:00 committed by GitHub
parent 892f9c13a2
commit a33904a57a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 6 additions and 90 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
engine/src/flutter/ci/licenses_golden/licenses_flutter
View File

@ -41216,7 +41216,6 @@ ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/font_change_util.dart + ../..
ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/font_fallback_data.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/font_fallbacks.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/fonts.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/frame_reference.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/frame_service.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/frame_timing_recorder.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/html/backdrop_filter.dart + ../../../flutter/LICENSE
@ -41226,6 +41225,7 @@ ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/html/clip.dart + ../../../flu
ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/html/color_filter.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/html/debug_canvas_reuse_overlay.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/html/dom_canvas.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/html/frame_reference.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/html/image.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/html/image_filter.dart + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/lib/web_ui/lib/src/engine/html/offset.dart + ../../../flutter/LICENSE
@ -44170,7 +44170,6 @@ FILE: ../../../flutter/lib/web_ui/lib/src/engine/font_change_util.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/font_fallback_data.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/font_fallbacks.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/fonts.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/frame_reference.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/frame_service.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/frame_timing_recorder.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/html/backdrop_filter.dart
@ -44180,6 +44179,7 @@ FILE: ../../../flutter/lib/web_ui/lib/src/engine/html/clip.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/html/color_filter.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/html/debug_canvas_reuse_overlay.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/html/dom_canvas.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/html/frame_reference.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/html/image.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/html/image_filter.dart
FILE: ../../../flutter/lib/web_ui/lib/src/engine/html/offset.dart

2
engine/src/flutter/lib/web_ui/lib/src/engine.dart
View File

@ -65,7 +65,6 @@ export 'engine/font_change_util.dart';
export 'engine/font_fallback_data.dart';
export 'engine/font_fallbacks.dart';
export 'engine/fonts.dart';
export 'engine/frame_reference.dart';
export 'engine/frame_service.dart';
export 'engine/frame_timing_recorder.dart';
export 'engine/html/backdrop_filter.dart';
@ -75,6 +74,7 @@ export 'engine/html/clip.dart';
export 'engine/html/color_filter.dart';
export 'engine/html/debug_canvas_reuse_overlay.dart';
export 'engine/html/dom_canvas.dart';
export 'engine/html/frame_reference.dart';
export 'engine/html/image.dart';
export 'engine/html/image_filter.dart';
export 'engine/html/offset.dart';

2
engine/src/flutter/lib/web_ui/lib/src/engine/html/bitmap_canvas.dart
View File

@ -12,13 +12,13 @@ import '../canvas_pool.dart';
import '../display.dart';
import '../dom.dart';
import '../engine_canvas.dart';
import '../frame_reference.dart';
import '../text/canvas_paragraph.dart';
import '../util.dart';
import '../vector_math.dart';
import 'clip.dart';
import 'color_filter.dart';
import 'dom_canvas.dart';
import 'frame_reference.dart';
import 'image.dart';
import 'painting.dart';
import 'path/path.dart';

0
engine/src/flutter/lib/web_ui/lib/src/engine/frame_reference.dart → engine/src/flutter/lib/web_ui/lib/src/engine/html/frame_reference.dart
View File

2
engine/src/flutter/lib/web_ui/lib/src/engine/html/picture.dart
View File

@ -10,12 +10,12 @@ import 'package:ui/ui.dart' as ui;
import '../dom.dart';
import '../engine_canvas.dart';
import '../frame_reference.dart';
import '../util.dart';
import '../vector_math.dart';
import 'bitmap_canvas.dart';
import 'debug_canvas_reuse_overlay.dart';
import 'dom_canvas.dart';
import 'frame_reference.dart';
import 'image.dart';
import 'path/path_metrics.dart';
import 'recording_canvas.dart';

2
engine/src/flutter/lib/web_ui/lib/src/engine/html/surface.dart
View File

@ -6,12 +6,12 @@ import 'package:meta/meta.dart';
import 'package:ui/ui.dart' as ui;
import '../dom.dart';
import '../frame_reference.dart';
import '../frame_service.dart';
import '../onscreen_logging.dart';
import '../semantics.dart';
import '../util.dart';
import '../vector_math.dart';
import 'frame_reference.dart';
import 'picture.dart';
import 'scene.dart';
import 'surface_stats.dart';

84
engine/src/flutter/lib/web_ui/test/engine/frame_reference_test.dart
View File

@ -1,84 +0,0 @@
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:test/bootstrap/browser.dart';
import 'package:test/test.dart';
import 'package:ui/src/engine.dart';
void main() {
internalBootstrapBrowserTest(() => testMain);
}
void testMain() {
group('CrossFrameCache', () {
test('Reuse returns no object when cache empty', () {
final CrossFrameCache<TestItem> cache = CrossFrameCache<TestItem>();
cache.commitFrame();
final TestItem? requestedItem = cache.reuse('item1');
expect(requestedItem, null);
});
test('Reuses object across frames', () {
final CrossFrameCache<TestItem> cache = CrossFrameCache<TestItem>();
final TestItem testItem1 = TestItem('item1');
cache.cache(testItem1.label, testItem1);
cache.commitFrame();
TestItem? requestedItem = cache.reuse('item1');
expect(requestedItem, testItem1);
requestedItem = cache.reuse('item1');
expect(requestedItem, null);
});
test('Reuses objects that have same key across frames', () {
final CrossFrameCache<TestItem> cache = CrossFrameCache<TestItem>();
final TestItem testItem1 = TestItem('sameLabel');
final TestItem testItem2 = TestItem('sameLabel');
final TestItem testItemX = TestItem('X');
cache.cache(testItem1.label, testItem1);
cache.cache(testItemX.label, testItemX);
cache.cache(testItem2.label, testItem2);
cache.commitFrame();
TestItem? requestedItem = cache.reuse('sameLabel');
expect(requestedItem, testItem1);
requestedItem = cache.reuse('sameLabel');
expect(requestedItem, testItem2);
requestedItem = cache.reuse('sameLabel');
expect(requestedItem, null);
});
test("Values don't survive beyond next frame", () {
final CrossFrameCache<TestItem> cache = CrossFrameCache<TestItem>();
final TestItem testItem1 = TestItem('item1');
cache.cache(testItem1.label, testItem1);
cache.commitFrame();
cache.commitFrame();
final TestItem? requestedItem = cache.reuse('item1');
expect(requestedItem, null);
});
test('Values are evicted when not reused', () {
final Set<TestItem> evictedItems = <TestItem>{};
final CrossFrameCache<TestItem> cache = CrossFrameCache<TestItem>();
final TestItem testItem1 = TestItem('item1');
final TestItem testItem2 = TestItem('item2');
cache.cache(testItem1.label, testItem1, (TestItem item) {
evictedItems.add(item);
});
cache.cache(testItem2.label, testItem2, (TestItem item) {
evictedItems.add(item);
});
cache.commitFrame();
expect(evictedItems.length, 0);
cache.reuse('item2');
cache.commitFrame();
expect(evictedItems.contains(testItem1), isTrue);
expect(evictedItems.contains(testItem2), isFalse);
});
});
}
class TestItem {
TestItem(this.label);
final String label;
}